FS#30535 - mysql: purpose to set CFLAGS/CXXFLAGS but didn't work

Attached to Project: Arch Linux
Opened by Lee.MaRS (leemars) - Wednesday, 04 July 2012, 12:09 GMT
Last edited by Andrea Scarpino (BaSh) - Wednesday, 04 July 2012, 13:20 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Andrea Scarpino (BaSh)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

In PKGBUILD of package mysql, I found this bug:

> # CFLAGS/CXXFLAGS as suggested upstream
> CFLAGS="-fPIC ${CFLAGS} -fno-strict-aliasing -DBIG_JOINS=1 -fomit-frame-pointer" \
> CXXFLAGS="-fPIC ${CXXFLAGS} -fno-strict-aliasing -DBIG_JOINS=1 -felide-constructors -fno-rtti" \
>
> cmake ../${pkgbase}-${pkgver} \

The space line makes the CFLAGS and CXXFLAGS ignored in later cmake.
This task depends upon

Closed by  Andrea Scarpino (BaSh)
Wednesday, 04 July 2012, 13:20 GMT
Reason for closing:  Fixed
Additional comments about closing:  On trunk
Comment by Andrea Scarpino (BaSh) - Wednesday, 04 July 2012, 13:14 GMT
We should use the -DCMAKE_CXX_FLAGS="-fPIC ${CXXFLAGS} -fno-strict-aliasing -DBIG_JOINS=1 -felide-constructors -fno-rtti" option.

EDIT: Fixed on trunk.
Comment by Dave Reisner (falconindy) - Wednesday, 04 July 2012, 13:14 GMT
CFLAGS and CXXFLAGS are marked for export by makepkg. They do not need to be re-exported if they're modified.
Comment by Andrea Scarpino (BaSh) - Wednesday, 04 July 2012, 13:17 GMT
Nice, I didn't know that.
Anyway I guess the proper way is to set them using the cmake option.

Loading...