FS#30414 - [ntp] systemd service should not fork

Attached to Project: Arch Linux
Opened by Ray (ataraxia) - Saturday, 23 June 2012, 14:29 GMT
Last edited by Dave Reisner (falconindy) - Saturday, 23 June 2012, 15:46 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To No-one
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description:
The ntpd.service file imported from systemd-arch-units allows ntpd to fork. systemd's recommendation is to avoid this when possible. For ntpd, this is easily done, as it provides a "-n" flag to disable it. Patch (against trunk version of this file rather than released) is attached.
   ntpd.service.patch (0.3 KiB)
This task depends upon

Closed by  Dave Reisner (falconindy)
Saturday, 23 June 2012, 15:46 GMT
Reason for closing:  Won't implement
Additional comments about closing:  Forking is the correct thing to do.
Comment by Dave Reisner (falconindy) - Saturday, 23 June 2012, 14:39 GMT
In this case, avoiding the fork is not possible. It's conceivable that you might want to order other daemons on systemd-timedated-ntp.target which is active only once NTP is fully up. We've gone back and forth on this quite a bit, and come to the conclusion that forking is the correct thing to do here.
Comment by Ray (ataraxia) - Saturday, 23 June 2012, 15:37 GMT
Ah, I see what you mean - the fork here helps avoid a race condition between ntpd and other things that may be associated with systemd-timedated-ntp.target. I'm fine with just closing this FS.

Maybe someday ntpd will take a name on the system DBus, and we can have the best of both worlds :)

Loading...