Community Packages

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#30225 - [nginx] config no longer in backup array, will overwrite on upgrade

Attached to Project: Community Packages
Opened by Dave Reisner (falconindy) - Saturday, 09 June 2012, 20:02 GMT
Last edited by Bartłomiej Piotrowski (Barthalion) - Friday, 29 June 2012, 06:13 GMT
Task Type Bug Report
Category Packages: Testing
Status Closed
Assigned To Bartłomiej Piotrowski (Barthalion)
Architecture All
Severity High
Priority High
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

1.2.1-2 makes a total mess of current nginx users config, thanks to:

https://projects.archlinux.org/svntogit/community.git/commit/trunk?h=packages/nginx&id=0fd4bd9dc80aba742434f69d2c93ba344d9450e3

You've moved config and left it out of the backup array. /etc/nginx/nginx.conf will be *overwritten* on upgrade. The best part is, there's zero notification about this.

Please either revert this insane change or have the decency to warn users via an install message and/or posting to aur-general that you're making *drastic* changes to a server package.
This task depends upon

Closed by  Bartłomiej Piotrowski (Barthalion)
Friday, 29 June 2012, 06:13 GMT
Reason for closing:  Implemented
Additional comments about closing:  Added post_upgrade and removed *.default files since 1.2.1-3.
Comment by Ionut Biru (wonder) - Saturday, 09 June 2012, 20:04 GMT
+1 to revert the configuration location. We want seamless upgrade path.
Comment by Dave Reisner (falconindy) - Saturday, 09 June 2012, 20:33 GMT
Apologies, the config is still in backup, but the rest of this report is still quite valid and disturbing. You've additionally nuked the logs/ and html/ symlinks that used to exist.
Comment by Evangelos Foutras (foutrelis) - Saturday, 09 June 2012, 20:42 GMT
My suggestion is to keep the existing changes, but add a post_upgrade message with
information about the location move and the need to fix the configuration for html/log
paths (now that the symlinks are gone). Or maybe just the log paths (who uses the default
nginx html directory anyway).
Comment by Evangelos Foutras (foutrelis) - Saturday, 09 June 2012, 20:47 GMT
May I also suggest that we do away with the /etc/nginx/*.default files? I don't
think they serve any purpose. (We get .pacnew files when the main files change.)
Comment by Bartłomiej Piotrowski (Barthalion) - Sunday, 10 June 2012, 12:06 GMT
@Dave Reisner: If nothing has changed, you're still developer. Do I really need to
remind you about purposes of *-testing repositories? If so, packages from testing
repo are expected to break something, need to be tested, and generally speaking can
eat your cat or dog. Of course, I had wrongly assumed that you'll read ArchWiki[1]
before enabling them and you're user experienced enough to check changes between pkgrels.

Do me a favour and don't complain about changes in server package. Nobody in his right
mind uses testing repositories on server. And before you start trolling again, I'll notify users
about changes, when nginx 1.2.1-2 will be moved into [community].

@Ionut Biru: I'll add compatibility symlinks, but I'll remove them sooner or later,
probably in 1.3 release.

@Evangelos Foutras: As I wrote already, I'll add post_upgrade message before moving
package to [community]. Removing *.default is good idea, thanks.

[1] https://wiki.archlinux.org/index.php/Testing#.5Btesting.5D
Comment by Dave Reisner (falconindy) - Sunday, 10 June 2012, 13:12 GMT
Thanks, I'm aware of what the testing repos are for.

Over in developer land, we post on arch-dev-public when we're breaking things.

When I replaced udev with systemd-tools in testing, I posted about it
- http://mailman.archlinux.org/pipermail/arch-dev-public/2012-May/022980.html

When I introduced pambase to testing, I posted about it:
- http://mailman.archlinux.org/pipermail/arch-dev-public/2012-June/023017.html

When we moved filesystem-2012.06 into testing and it required user intervention, I posted about it:
- http://mailman.archlinux.org/pipermail/arch-dev-public/2012-June/023037.html

Testing isn't meant to punish people. Yes, I expect things might break. I also expect that maintainers have the decency to write a few sentences and push the send button so that they're not left to their own devices when they get the upgrade. Having the forethought to add an install message before this hit testing would have saved you this bug report.

Feel free to close this however you want. I'll go back to maintaining my own nginx package.
Comment by Ionut Biru (wonder) - Sunday, 10 June 2012, 13:34 GMT
compatibily links are not important. What is important is no notify about the change in .install
Comment by Dan McGee (toofishes) - Saturday, 16 June 2012, 15:11 GMT
This is a rediculously silly change to make for no good reason. Thanks for making me want to move this to [extra] so we can make sane packaging decisions.
Comment by Bartłomiej Piotrowski (Barthalion) - Saturday, 16 June 2012, 18:24 GMT
So this is how we discuss changes now, good to know.
If you call making junk from package "sane packaging decisions", feel free to move it.
Of course it's easier to maintain messy package and just bump pkgver every upgrade than
make changes and follow any standards (common sense too). Even Debian has cleaner nginx
than us, but who cares, Arch must be different.
Comment by Dan McGee (toofishes) - Saturday, 16 June 2012, 22:24 GMT
Sorry, that was frustration speaking. I'm just not sure what the rationale is for this change- sure, it might make things a bit cleaner, but it is causing a lot of pain to every existing user to update/move/merge any and all of their existing configuration files.

At the very least we need a post_install messages saying things moved (and hopefully why).

Loading...