FS#30145 - [ScummVM] PKGBUILD needs cleanup
Attached to Project:
Arch Linux
Opened by Rasmus Steinke (rasi) - Tuesday, 05 June 2012, 18:01 GMT
Last edited by Jürgen Hötzel (juergen) - Thursday, 07 June 2012, 12:32 GMT
Opened by Rasmus Steinke (rasi) - Tuesday, 05 June 2012, 18:01 GMT
Last edited by Jürgen Hötzel (juergen) - Thursday, 07 June 2012, 12:32 GMT
|
Details
The ScummVM PKGBUILD has some mistakes that really should be
fixed.
-Most important: the data engine files are not copied over. -the sdl engine argument is not needed for linux -the flac directory does not need to be specified -flac is given as an argument, but not as a dependency -faad is disabled for no apparent reason Most of the above can be fixed by simply using make install instead of manual installation of every single file. Fixed PKGBUILD in attachment 
PKGBUILD
(0.7 KiB)
|
This task depends upon
Closed by Jürgen Hötzel (juergen)
Thursday, 07 June 2012, 12:32 GMT
Reason for closing: Fixed
Additional comments about closing: Thanks for your contribution. I just release: scummvm-1.4.1-2
Just 2 fixes:
* split again to (build/package)
* added missing desktop file again
Thursday, 07 June 2012, 12:32 GMT
Reason for closing: Fixed
Additional comments about closing: Thanks for your contribution. I just release: scummvm-1.4.1-2
Just 2 fixes:
* split again to (build/package)
* added missing desktop file again
--enable-release is missing from arguments.
fixed PKGBUILD:
# $Id: PKGBUILD 150218 2012-02-15 08:08:05Z juergen $
# Maintainer: juergen <juergen@archlinux.org>
# Contributor: Manolis Tzanidakis, Petter Gundersen
pkgname=scummvm
pkgver=1.4.1
pkgrel=1
pkgdesc="A 'virtual machine' for several classic graphical point-and-click adventure games."
arch=('i686' 'x86_64')
license=('GPL')
url="http://www.scummvm.org/"
depends=('libmad' 'sdl' 'fluidsynth' 'flac' 'faad2')
source=(http://downloads.sourceforge.net/sourceforge/${pkgname}/${pkgname}-${pkgver}.tar.bz2)
md5sums=('aa094c2224aad22d5340a1d2d919c883')
build() {
cd "${srcdir}"/${pkgname}-${pkgver}
./configure --disable-debug \
--enable-release \
--prefix=/usr
make
make DESTDIR=$startdir/pkg install
}
add libmad and libvorbis to the dependencies too. Most have those installed anyway. Doesnt change the fact, that those are more or less mandatory Dependencies.
# $Id: PKGBUILD 150218 2012-02-15 08:08:05Z juergen $
# Maintainer: juergen <juergen@archlinux.org>
# Contributor: Manolis Tzanidakis, Petter Gundersen
pkgname=scummvm
pkgver=1.4.1
pkgrel=1
pkgdesc="A 'virtual machine' for several classic graphical point-and-click adventure games."
arch=('i686' 'x86_64')
license=('GPL')
url="http://www.scummvm.org/"
depends=('libmad' 'sdl' 'fluidsynth' 'flac' 'faad2' 'libvorbis' 'libmad')
source=(http://downloads.sourceforge.net/sourceforge/${pkgname}/${pkgname}-${pkgver}.tar.bz2)
md5sums=('aa094c2224aad22d5340a1d2d919c883')
build() {
cd "${srcdir}"/${pkgname}-${pkgver}
./configure --disable-debug \
--enable-release \
--prefix=/usr
make
make DESTDIR=$startdir/pkg install
}