FS#30128 - [rawtherapee] use different name suffix

Attached to Project: Community Packages
Opened by Troy Sankey (sankeytm) - Sunday, 03 June 2012, 20:06 GMT
Last edited by Lukas Jirkovsky (6xx) - Sunday, 17 June 2012, 13:41 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Lukas Jirkovsky (6xx)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Use this for the build:
cmake -DCACHE_NAME_SUFFIX="4"

RawTherapee devs want to standardize the name suffix.
This task depends upon

Closed by  Lukas Jirkovsky (6xx)
Sunday, 17 June 2012, 13:41 GMT
Reason for closing:  Won't implement
Additional comments about closing:  There's no need for specifying suffix.
Comment by Jaroslav Lichtblau (Dragonlord) - Thursday, 07 June 2012, 18:45 GMT
Any further info to this?
Comment by Troy Sankey (sankeytm) - Thursday, 07 June 2012, 23:16 GMT
This should change the names of the local config/cache directories from ~/.{config|cache}/RawTherapee to ~/.{config|cache}/RawTherapee4.
Comment by Lukas Jirkovsky (6xx) - Friday, 08 June 2012, 07:46 GMT
Why we should support it? We do not support Rawtherapee 3 and RT 5 is still in the distant future, so I don't see any point in doing this.
Comment by Troy Sankey (sankeytm) - Saturday, 09 June 2012, 20:47 GMT
I agree it seems unneccessary, but I'm just reporting what I've been told. Let me just ask if the current config files are compatible with the new ones.

Also, can you build with the mercurial repository instead of tarballs? RT uses mercurial tags to fill in the branch/version number in AboutThisBuild.txt, but currently the about->version window does not show any branch or version info. This will help with RT bugs reported by arch users who just want to copy+paste from the GUI.
Comment by Troy Sankey (sankeytm) - Monday, 11 June 2012, 18:22 GMT
Everything is compatible so there should not be a problem leaving the CACHE_NAME_SUFFIX as-is.
Comment by Lukas Jirkovsky (6xx) - Sunday, 17 June 2012, 13:40 GMT
OK then, I will close this bug.

As for the version in tarball build: Bug reporter can always say what version it is, I personally never had a problem with that when reporting bugs. I'd like to stick with tarballs, because cloning the whole repository is slow.

I hope the next release* of RT will include the patch from
http://code.google.com/p/rawtherapee/issues/detail?id=1342
that completely removes the need for mercurial when building from release tarball and it also should fix the missing version number in the about dialog.

* release 4.0.10, I'm going to skip 4.0.9 as it is unusable without patching (http://code.google.com/p/rawtherapee/issues/detail?id=1399, will be fixed in the next release)

Loading...