FS#30095 - [rsync] add systemd service file

Attached to Project: Arch Linux
Opened by Marius (65kid) - Friday, 01 June 2012, 11:07 GMT
Last edited by Pierre Schmitz (Pierre) - Thursday, 07 June 2012, 06:29 GMT
Task Type Feature Request
Category Packages: Extra
Status Closed
Assigned To Pierre Schmitz (Pierre)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Please add the attached systemd service file to the rsync package.

no response upstream:
https://bugzilla.samba.org/show_bug.cgi?id=8416

there is a small problem with this service file: when the service is stopped by systemd with SIGTERM, rsync returns a non-zero exit code. Therefore systemd considers the service failed after it has been stopped. I filed a bug about this upstream:
https://bugzilla.samba.org/show_bug.cgi?id=8967

I'm sure this can be worked around somehow in the service file, but IMHO this is not a real problem and we should just wait for upstream to fix this. Other opinions welcome...
This task depends upon

Closed by  Pierre Schmitz (Pierre)
Thursday, 07 June 2012, 06:29 GMT
Reason for closing:  Implemented
Comment by Marius (65kid) - Friday, 01 June 2012, 19:35 GMT
regarding the "small problem", the rsync devs don't seem to consider this a bug. Anyway, I just realized that systemd has an easy fix for this: prefix /usr/bin/rsync with a -
But in this case the service will never be considered "failed", even if it actually does (for whatever reason).
Comment by Pierre Schmitz (Pierre) - Thursday, 07 June 2012, 06:29 GMT
Supressing any exit code is probably also a bad idea. This should be fixed in rsync (or systemd)

Loading...