FS#30038 - [libvirt] sysctl.d/libvirtd should be in /usr/lib

Attached to Project: Community Packages
Opened by Sébastien Luttringer (seblu) - Sunday, 27 May 2012, 19:20 GMT
Last edited by Sergej Pupykin (sergej) - Monday, 28 May 2012, 13:23 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Sergej Pupykin (sergej)
Architecture All
Severity Low
Priority Low
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

$ pacman -Qo /etc/sysctl.d/libvirtd
/etc/sysctl.d/libvirtd is owned by libvirt 0.9.12-4

This file should be in /usr/lib/systctl.d/libvirtd and not in /etc, as initscripts (and systemd) handle this correctly since some version.

Cheers,
This task depends upon

Closed by  Sergej Pupykin (sergej)
Monday, 28 May 2012, 13:23 GMT
Reason for closing:  Fixed
Comment by Sergej Pupykin (sergej) - Monday, 28 May 2012, 07:44 GMT
From sysctl file comments:

> Set this number at least as large as 128 * (number of virtual disks on the host)

I think it may (and probably should) be modified by user, so /etc location is better.
Comment by Sébastien Luttringer (seblu) - Monday, 28 May 2012, 12:48 GMT
Yes, users copy /usr/sysctl.d/libvirtd to /etc/sysctl.d/libvirtd and it will override /usr one. This works as udev rules in rules.d or systemd unit files.
This avoid .pacnew and allow user to overrides local modification. Here, i don't think this file will be update frequently, but it's the most consistent way of providing systcl.d files in packages.
Comment by Sébastien Luttringer (seblu) - Monday, 28 May 2012, 12:51 GMT
Related to initscripts, packagers should provides tmpfiles in /usr/lib/tmpfiles.d and not in /etc/tmpfiles.d/. Same with sysctld.

Loading...