FS#29965 - [gnome-disk-utility] dosfstools should be a dependency of gnome-disks

Attached to Project: Arch Linux
Opened by fabio (fabioamd) - Monday, 21 May 2012, 12:50 GMT
Last edited by Jan de Groot (JGC) - Wednesday, 25 September 2013, 11:00 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Ionut Biru (wonder)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 2
Private No

Details

Description:
if dosfstools is not installed we can't format pendrives with gnome-disks
it should be a dependency of that package
This task depends upon

Closed by  Jan de Groot (JGC)
Wednesday, 25 September 2013, 11:00 GMT
Reason for closing:  Fixed
Additional comments about closing:  Added optdepends to udisks2.
Comment by Jelle van der Waa (jelly) - Monday, 21 May 2012, 13:11 GMT
It should really be an optdepend, since some people don't use vfat formatted penrives (shrug)
Comment by fabio (fabioamd) - Monday, 21 May 2012, 14:07 GMT
ok, but if you try to format pendrives with vfat it gives you an error, and "normal people" doesn't understand that:

Error creating file system: Cannot run mkfs: cannot spawn 'mkfs.vfat -I /dev/sdc': Failed to execute child process "mkfs.vfat" (No such file or directory)

means: install dosfstools.
Comment by Matthias Dienstbier (fs4000) - Monday, 21 May 2012, 14:07 GMT
Gnome-disk-utility is just the frontend. Udisks2 does all the partitioning and formatting. There are much more programs involved: http://cgit.freedesktop.org/udisks/tree/src/udiskslinuxfsinfo.c
Should we add an optional dependency for all of them? Dosfstools might make sense because it isn't in base and quite common.
Comment by fabio (fabioamd) - Monday, 21 May 2012, 14:13 GMT
there isn't anything that can be done to simplify? Or is right that the (normal) user must get that error? (we are talking about GNOME and not terminal)
Comment by Ionut Biru (wonder) - Monday, 21 May 2012, 14:24 GMT
i will add it to optdepend for udisks2, in the same way parted is right now.
Comment by fabio (fabioamd) - Monday, 21 May 2012, 14:38 GMT
in a perfect world, gnome-disk-tools should call packagekit that should offer a window to the user to install the fat32 file system support right?
Comment by Matthias Dienstbier (fs4000) - Monday, 21 May 2012, 15:11 GMT
I think so, but PackageKit in Arch wouldn't be able to determine which package has mkfs.vfat. There's still a lot of work to be done.
Comment by fabio (fabioamd) - Monday, 21 May 2012, 15:13 GMT
I know, I REALLY would like to help in that...
Comment by Jelle van der Waa (jelly) - Monday, 21 May 2012, 18:21 GMT
Archlinux is for advanced users, if you can't figure out what "no such file or directory " is you shouldn't use it imo ;)
Comment by fabio (fabioamd) - Monday, 21 May 2012, 18:30 GMT
so let's remove all dependency resolving system, a very advanced user doesn't need that.
Comment by Hussam Al-Tayeb (hussam) - Wednesday, 12 June 2013, 11:20 GMT
Or at least stop pretending to still have a KISS distribution/packaging system now that the use of optional dependencies is in place.

If the upstream developer intended for a package to be dependency, it should be in 'depends' array and NOT 'optdepends' even if it is not linked against/called.
if it is not intended by upstream developers to be a dependency, it should not be in 'depends' or optdepends'. It should be in some 'recommended' list.
Comment by Ashley Whetter (AWhetter) - Thursday, 18 July 2013, 16:45 GMT
I don't think it should be a depends because it's not for gparted, because gparted behaves sensibly. It will grey out FAT as on option if dosfstools isn't installed. In my opinion gnome-disk-utility should do the same, and then it makes /absolute/ sense for dosfstools to be in optdepends.

Loading...