FS#29877 - [wifi-select] does not handle special character properly.

Attached to Project: Community Packages
Opened by Doug Penner (DarwinSurvivor) - Sunday, 13 May 2012, 20:26 GMT
Last edited by Sergej Pupykin (sergej) - Friday, 02 November 2012, 13:54 GMT
Task Type Bug Report
Category Upstream Bugs
Status Closed
Assigned To Sergej Pupykin (sergej)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
If you connect to a network that has a special character (such as "$") in the name or password, it will fail to connect because wifi-select uses full quotes " instead of apostraphes ' in the generated network.d/ configuration file which causes netcfg to try to INTERPRET the value instead of simply reading. Changing the "s to 's should fix the problem

Ex: currently the password field will be
password = "my$superpassword"
which will make it think that $mysuperpassword is a variable (which is blank) and cause the password to become "my"
It *should* be
password = 'my$superpassword'
This way the password is not interpreted but simply read.

The password field is currently and issue for me, but the other fields use the same system and are thus also susceptible to this problem.

Also note: the 's should be escaped (as they are a 100% legal password character).

Additional info:
* package version(s)
* config and/or log files etc.
netcfg 2.8.2-1
wifi-select 1.2-1


Steps to reproduce:
Connect to any wifi network where the ESSID or password contain a special "sh" or "bash" character (", ', $, etc) that are interpreted within quotes.
This task depends upon

Closed by  Sergej Pupykin (sergej)
Friday, 02 November 2012, 13:54 GMT
Reason for closing:  Won't implement
Additional comments about closing:  moved to aur https://aur.archlinux.org/packages.php?I D=64232
Comment by Sergej Pupykin (sergej) - Friday, 18 May 2012, 11:43 GMT
I think you should report problem to upstream, probably here - https://bbs.archlinux.org/viewtopic.php?id=63973&p=6 (according to README)
Comment by Doug Penner (DarwinSurvivor) - Friday, 18 May 2012, 12:19 GMT
Ok, I didn't know this package *had* an upstream. It's specicific to netcfg and netcfg seems to only exist on arch, so I figured it used the arch bug tracker. I will raise the issue in the attached forum thread.
Comment by Greg (dolby) - Friday, 24 August 2012, 16:10 GMT
Maybe this package needs to go now that netcfg includes wifi-menu which does the same.

Loading...