Arch Linux

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#29610 - [deluge] /etc/rc.d/deluged missing [[ -z $PID ]] before kill -0

Attached to Project: Arch Linux
Opened by Henry Tung (compgamer89) - Wednesday, 25 April 2012, 04:54 GMT
Last edited by Allan McRae (Allan) - Friday, 16 November 2012, 12:39 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Jan Alexander Steffens (heftig)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 2
Private No

Details

Description:

/etc/rc.d/deluged
-kill -0 $PID || PID=
+[[ -z $PID ]] || kill -0 $PID || PID=

Suppresses kill usage error message when PIDFILE does not exist, for good form.

On cursory examination, seems like deluge-web has the same effect.

Additional info:
* package version(s)
1.3.5-1
* config and/or log files etc.
None relevant.

Steps to reproduce:
1) Install deluge
2) Make sure /run/deluge/deluged.pid is removed
3) /etc/rc.d/deluged start

On a side note, mild security concern: the pidfiles are writable by the deluge user; technically speaking, this could mean that if the deluge daemon is compromised, the pidfile contents could be overwritten with anything, including for instance the string "1 2 3 4 5 6 7 8 ...", causing an

/etc/rc.d/deluged stop

to kill the entire system. Could possibly obtain and store the pid in the rc.d script itself, instead of depending on deluge to do so, to avoid putting deluge write perms on the pidfile? My two cents.
This task depends upon

Closed by  Allan McRae (Allan)
Friday, 16 November 2012, 12:39 GMT
Reason for closing:  Won't fix
Additional comments about closing:  move to systemd
Comment by Mathias Rohnstock (drmonty) - Sunday, 22 July 2012, 11:41 GMT
/etc/rc.d/deluge-web got the same issue.

Loading...