FS#29560 - rc.d script provided with radvd 1.8.5-3 calls add_daemon and rm_daemon with wrong parameters

Attached to Project: Community Packages
Opened by Markus Mattinen (Choris) - Sunday, 22 April 2012, 16:59 GMT
Last edited by Sébastien Luttringer (seblu) - Sunday, 22 April 2012, 21:29 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Sébastien Luttringer (seblu)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
The rc.d script provided with package radvd 1.8.5-3 calls the functions add_daemon and rm_daemon with wrong parameters.
As a result, even though radvd is successfully started with rc.d start radvd, it shows up as [STOPPED] in the output of rc.d list -a.


Affected parts of radvd.rc in package radvd 1.8.5-3:

NAME='IPv6 Router Advertisement Daemon'
...
add_daemon $NAME
...
rm_daemon $NAME

The correct syntax would be:

add_daemon ${0##*/}
...
rm_daemon ${0##*/}


Attached a patch to fix the bug.
   radvd.rc.patch (0.6 KiB)
This task depends upon

Closed by  Sébastien Luttringer (seblu)
Sunday, 22 April 2012, 21:29 GMT
Reason for closing:  Fixed
Additional comments about closing:  radvd-1.8.5-4
Comment by Dave Reisner (falconindy) - Sunday, 22 April 2012, 17:12 GMT
I think there's a pretty good case for just hardcoding the name.
Comment by Sébastien Luttringer (seblu) - Sunday, 22 April 2012, 20:13 GMT
ugly error.

Hardcoding avoid duplication for package like bird or quagga, where scripts is shared accross daemons.

Loading...