FS#29528 - [vsftpd] Missing LDFLAGS, wrong CFLAGS.

Attached to Project: Community Packages
Opened by Jason William Walton (jasonww) - Wednesday, 18 April 2012, 16:39 GMT
Last edited by Bartłomiej Piotrowski (Barthalion) - Wednesday, 18 April 2012, 17:35 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Bartłomiej Piotrowski (Barthalion)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

What the line should be like:

CFLAGS="${CFLAGS} -fPIE" LINK='' LDFLAGS="-fPIE -pie ${LDFLAGS} -Wl,-z,now"

LINK is empty to prevent stripping during linking. (makepkg does it anyway, and avoids frustration when someone intents to make a debug build.)

Currently -fPIC is passed to CFLAGS probably because the packager didn't figure out why it failed to build.

fPIE/pie/now: This is what upstream intents, as such it should be honored.
This task depends upon

Closed by  Bartłomiej Piotrowski (Barthalion)
Wednesday, 18 April 2012, 17:35 GMT
Reason for closing:  Fixed
Additional comments about closing:  vsftpd 3.0.0-2

Loading...