FS#29057 - [filesystem] /etc/os-replace should be part of filesystem package and replace /etc/arch-release

Attached to Project: Arch Linux
Opened by Keshav Amburay (the.ridikulus.rat) - Thursday, 22 March 2012, 14:55 GMT
Last edited by Tom Gundersen (tomegun) - Saturday, 09 June 2012, 17:09 GMT
Task Type Bug Report
Category Packages: Core
Status Closed
Assigned To Tom Gundersen (tomegun)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 4
Private No

Details

Description:
The /etc/os-release file is not systemd specific and should really be part of the filesystem package. Ideally it should replace /etc/arch-release in core/filesystem or alteast /etc/arch-release should be a symlink to /etc/os-release.

The reason for this is detecting whether the running distro is Archlinux in patched sources of package like in case of https://bugs.archlinux.org/task/29037 (which I wrote thinking os-release is installed in all Archlinux systems, until that bugs report). Instead of fixing that patch, I think this should be fixed in the filesystem package.

Additional info:
* Patch in question present in extra/grub2-common-1:2.00beta2-2
* /etc/os-release in extra/systemd
* /etc/-arch-release in core/filesystem
This task depends upon

Closed by  Tom Gundersen (tomegun)
Saturday, 09 June 2012, 17:09 GMT
Reason for closing:  Fixed
Comment by Dave Reisner (falconindy) - Friday, 23 March 2012, 01:39 GMT
No, please fix your patch. It's broken for other reasons as well, and I've no clue why it was applied. You clearly didn't test it properly, especially given that you freely admit in a forum thread that you don't even use the script [1], and you sent it to the wrong place. It belongs upstream, not here.

grub-mkconfig is clearly intended to be POSIX compliant, and yet you've used bash-specific syntax (incorrectly, I might add):

if grep -q <pattern> <file>; then stuff; fi

There is no need for using [[ ]]. It's not part of if's syntax.

And, to top it all off, we can't simply just get rid of /etc/arch-release.

Please, don't make silly excuses. Fix your patch or just request that it be removed here, and submit it upstream where it belongs.

[1] https://bbs.archlinux.org/viewtopic.php?pid=1074558#p1074558
Comment by Keshav Amburay (the.ridikulus.rat) - Friday, 23 March 2012, 12:34 GMT
I checked the generated config. I just didn't replace my manual grub.cfg with this generated one. OK maybe POSIX compliance issues were there.

Upstream won't accept distro specific patches. The problem is our kernel naming scheme which does not contain any version numbers. Upstream expects kernel and initramfs files to have the version numbers in the filenames.
Comment by Tom Gundersen (tomegun) - Sunday, 03 June 2012, 00:34 GMT
This file will be added to the next filesystem release. The current arch-release will be kept though.

Loading...