FS#28973 - [devtools] usage() function in mkarchroot called with parameter

Attached to Project: Arch Linux
Opened by Daniel Oertwig (DanielOertwig) - Saturday, 17 March 2012, 21:55 GMT
Last edited by Eric Belanger (Snowman) - Thursday, 15 November 2012, 22:41 GMT
Task Type Bug Report
Category Arch Projects
Status Closed
Assigned To Pierre Schmitz (Pierre)
Architecture All
Severity Very Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Just a very small issue I found while looking through mkarchroot script:

It says:
-------------------------------------------------
# usage: usage <exitvalue>
usage() {
# ...
exit 1
}
-------------------------------------------------

And is used according to that some lines further down the script in the getopts case 'h':
-------------------------------------------------
h|?) usage 0 ;;
-------------------------------------------------

This seems to be in no way critical/fatal/problematic to the actual function of the script. I think it's just not "nice" :)
This task depends upon

Closed by  Eric Belanger (Snowman)
Thursday, 15 November 2012, 22:41 GMT
Reason for closing:  Fixed
Additional comments about closing:  devtools 20121115-1

Loading...