FS#28504 - [mkinitcpio] allow LABEL and UUID for resume parameter

Attached to Project: Arch Linux
Opened by Matthias Dienstbier (fs4000) - Saturday, 18 February 2012, 14:59 GMT
Last edited by Dave Reisner (falconindy) - Sunday, 25 March 2012, 02:27 GMT
Task Type Bug Report
Category Packages: Core
Status Closed
Assigned To Dave Reisner (falconindy)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

If we use resolve_device in the resume hook, it would be possible to use something like resume=LABEL=Swap or resume=UUID=... as it is possible for the root parameter.

Simple patch is attached but there might be better solutions as vanilla hibernation only needs major and minor. Tuxonice is not considered at all.
   resume.patch (1.6 KiB)
This task depends upon

Closed by  Dave Reisner (falconindy)
Sunday, 25 March 2012, 02:27 GMT
Reason for closing:  Implemented
Additional comments about closing:  testing/mkinitcpio-0.8.5
Comment by Dave Reisner (falconindy) - Sunday, 19 February 2012, 00:17 GMT
Thanks for the patch. It would have been nice if it not had so many unrelated changes. There's really only 2 lines that needs to be altered, but the hook does need some overall cleanup.
Comment by Dave Reisner (falconindy) - Sunday, 11 March 2012, 02:37 GMT
Got around to rewriting this, no idea if it works. Feel like giving the attached hook a test drive?
   resume (1.2 KiB)
Comment by Matthias Dienstbier (fs4000) - Sunday, 11 March 2012, 09:56 GMT
Standard hibernation with LABEL= works.

If you test for valid content of $resume you could also treat y as invalid as the user most likely has used resume without a value.
Comment by Dave Reisner (falconindy) - Sunday, 11 March 2012, 13:40 GMT
Hmmm, I see your point, but that's taken care of implicitly by resolve_device. It won't wait on an invalid device name -- it'll simply fail all the tests in the function and return 1. That will end the case statement back in the resume hook and it'll throw an error.
Comment by Dave Reisner (falconindy) - Saturday, 17 March 2012, 03:08 GMT
http://projects.archlinux.org/mkinitcpio.git/commit/?id=0a972c

Due for 0.8.5

Loading...