FS#28240 - [samba] uses dbus uid and gid

Attached to Project: Arch Linux
Opened by Neil Darlow (neildarlow) - Friday, 03 February 2012, 15:52 GMT
Last edited by Tobias Powalowski (tpowa) - Friday, 02 March 2012, 08:43 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Tobias Powalowski (tpowa)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
The samba startup script has hardcoded uid and gid values (81) used to create /var/run/samba and /var/log/samba if they don't already exist.

The Arch Wiki has these uid and gid assigned to dbus and they are present in /etc/passwd et. al.

I would suggest that the Wiki should define an uid and gid for samba and that the samba pkgbuild should respect those values.

Additional info:
* samba-3.6.3-1
* /etc/rc.d/samba

Steps to reproduce:
1) Examine /etc/passwd on a system with dbus/dbus-core installed
2) dbus is present in those files as uid and gid 81
3) Examine /etc/rc.d/samba and notice the use of the reserved dbus uid and gid:

if [ ! -x /var/run/samba ] ; then
install -m755 -g 81 -o 81 -d /var/run/samba
fi
if [ ! -x /var/log/samba ] ; then
install -m755 -g 81 -o 81 -d /var/log/samba
fi
This task depends upon

Closed by  Tobias Powalowski (tpowa)
Friday, 02 March 2012, 08:43 GMT
Reason for closing:  Fixed
Additional comments about closing:  3.6.3-2
Comment by Neil Darlow (neildarlow) - Saturday, 04 February 2012, 15:23 GMT
Looking further at this, the log files created in /var/log/samba are owned root:root.

It might be better to just remove the -g 81 -o 81 permissions from the directory creation logic. This would negate the need to do anything for existing installations and new ones would assume the correct permissions.

Loading...