Arch Linux

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#28066 - [libarchive] cannot unpack zip archives made in msdos mode, lots of AUR packages broken (with patch)

Attached to Project: Arch Linux
Opened by Andrzej Giniewicz (Giniu) - Monday, 23 January 2012, 12:36 GMT
Last edited by Dave Reisner (falconindy) - Thursday, 26 January 2012, 11:18 GMT
Task Type Bug Report
Category Packages: Core
Status Closed
Assigned To Dave Reisner (falconindy)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 2
Private No

Details

Description:

libarchive 3.0.3 includes bug that makes bsdtar fail on extracting zip files that were created in msdos mode.

In result, multiple packages that use zip files created on Windows (and include directories inside) cannot be built and stop on "extracting" stage with error "Can't remove already-existing dir". The bug was fixed upstream ( http://code.google.com/p/libarchive/issues/detail?id=225 ) and will be part of next release, but I believe it's so important on Arch (lots of AUR is broken now!) that it should be patched before official release.

I made minimal patch based on revision mentioned in bug report (skipped comments and tests), and verified that it works.
   zip.patch (0.5 KiB)
This task depends upon

Closed by  Dave Reisner (falconindy)
Thursday, 26 January 2012, 11:18 GMT
Reason for closing:  Fixed
Additional comments about closing:  libarchive 3.0.3-3
Comment by Dave Reisner (falconindy) - Monday, 23 January 2012, 19:50 GMT
This seems to break more than it fixes according to http://code.google.com/p/libarchive/issues/detail?id=231

Waiting for some sort of stability before backporting anything.
Comment by Andrzej Giniewicz (Giniu) - Monday, 23 January 2012, 20:19 GMT
this issue must come out with correlation to some other changes to trunk. In 3.0.3 + patch all tests pass without single failure.
Comment by Andrzej Giniewicz (Giniu) - Tuesday, 24 January 2012, 13:41 GMT
The upstream #231 is identified already - and "fixed" by test case change (timezone settings for MSDOS archives influences the dates of extracted files). It means that this patch changes major issue like "msdos archives not working at all" into minor issue like "msdos archives extracts but ignores timezone setting". The patch does not change anything for other files that are correctly identified (so those that are working now), which is confirmed by 100% doctest coverage.

The change was also merged from trunk into 3.0.x branch.
Comment by Dave Reisner (falconindy) - Wednesday, 25 January 2012, 03:25 GMT
backported both fixes to keep the test suite happy. libarchive 3.0.3-3 is in [testing].

Loading...