FS#27953 - [xmms]

Attached to Project: Arch Linux
Opened by cyberic (cyberic) - Sunday, 15 January 2012, 23:34 GMT
Last edited by Eric Belanger (Snowman) - Tuesday, 17 January 2012, 03:40 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Eric Belanger (Snowman)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
The PKGBUILD is too specific to x86.
I tried to build xmms on ARM, and the mp3 playing routines were built with x86 MMX optimization...

Here is the diff for a better PKGBUILD, I think:

--- orig/xmms/PKGBUILD 2012-01-15 06:04:46.000000000 +0100
+++ xmms/PKGBUILD 2012-01-16 00:07:52.931889001 +0100
@@ -50,10 +50,10 @@
patch -p1 < ../xmms-1.2.10-fonts.patch
patch -p1 < ../xmms-1.2.11-CVE-2007-0653.0654.patch

- if [ "$CARCH" == "x86_64" ]; then
- SIMDOPT="--disable-simd"
- else
+ if [ "$CARCH" == "i686_64" ]; then
SIMDOPT="--enable-simd"
+ else
+ SIMDOPT="--disable-simd"
fi
./configure --prefix=/usr --mandir=/usr/share/man $SIMDOPT
make
This task depends upon

Closed by  Eric Belanger (Snowman)
Tuesday, 17 January 2012, 03:40 GMT
Reason for closing:  Fixed
Comment by cyberic (cyberic) - Sunday, 15 January 2012, 23:37 GMT
There is a typo, :
+ if [ "$CARCH" == "i686_64" ]; then

should be:
+ if [ "$CARCH" == "i686" ]; then
Comment by Pierre Schmitz (Pierre) - Monday, 16 January 2012, 14:08 GMT
I guess as we don't provide any ARM support this isn't a real issue. (No idea why you posted this, but we cant fix ARM related problems)
Comment by cyberic (cyberic) - Monday, 16 January 2012, 14:29 GMT
This is not really an arm problem.
But the test in the PKGBUILD is wrong: the optimization should only apply to i686 arch.
If one day another architecture is added, this will break as well.

With this fix applied, the PKGBUILD can be used as is on any other architecture, which is great, even if not supported.

Loading...