Community Packages

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#27855 - [tinyproxy] PKGBUILD fix: pid file wrong and mkdir not needed anymore

Attached to Project: Community Packages
Opened by SanskritFritz (SanskritFritz) - Friday, 06 January 2012, 21:12 GMT
Last edited by Lukas Fleischer (lfleischer) - Monday, 23 January 2012, 13:57 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Lukas Fleischer (lfleischer)
Architecture All
Severity Very Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description: Followup to  FS#27836 . Please modify the PKGBUILD as follows:

Delete, this is not needed anymore:
if [ ! -d /var/run/tinyproxy ]; then
mkdir -p /var/run/tinyproxy && chown nobody:nobody /var/run/tinyproxy
fi

Modify the pid file location like this:
[ -z "$PID" ] && rm -f /var/run/tinyproxy/tinyproxy.pid && \
/usr/sbin/tinyproxy -c /etc/tinyproxy/tinyproxy.conf 2>/dev/null


Additional info: Note that these problems dont cause any problems in running tinyproxy normally. However when tinyproxy crashes, the pid file will not be deleted on start.

* package version(s) tinyproxy 1.8.3-1
This task depends upon

Closed by  Lukas Fleischer (lfleischer)
Monday, 23 January 2012, 13:57 GMT
Reason for closing:  Fixed
Additional comments about closing:  Fixed in 1.8.3-3.
Comment by Ionut Biru (wonder) - Friday, 06 January 2012, 21:19 GMT
why not use directly /run/tinyproxy... ?
Comment by SanskritFritz (SanskritFritz) - Friday, 06 January 2012, 21:30 GMT
Because upstream decided so. The directory is configurable in /etc/tinyproxy/tinyproxy.conf, but I wouldnt expect everybody to change the config for the package sake.
Comment by Ionut Biru (wonder) - Friday, 06 January 2012, 21:31 GMT
i mean in our script, right now /var/run is a symlink to /run.

[ -z "$PID" ] && rm -f /run/tinyproxy/tinyproxy.pid && \
Comment by SanskritFritz (SanskritFritz) - Friday, 06 January 2012, 21:32 GMT
On the other hand, the package could set it to /var/run/ of course...
Comment by SanskritFritz (SanskritFritz) - Friday, 06 January 2012, 21:33 GMT
Ah you mean this. This is up to you of course. I mimicked the behaviour of the stunnel package.
Comment by Lukas Fleischer (lfleischer) - Monday, 23 January 2012, 12:59 GMT
I agree with the new PID file location. We can't just remove the mkdir(1) invocation, though. Otherwise, tinyproxy won't start when we `pacman -S tinyproxy && rc.d start tinyproxy`. There's a couple of alternatives to doing this in the "rc.d" script, of course. Not sure what is the right thing here...
Comment by SanskritFritz (SanskritFritz) - Monday, 23 January 2012, 13:11 GMT
Again, check out the stunnel package for the model.
Comment by Lukas Fleischer (lfleischer) - Monday, 23 January 2012, 13:31 GMT
Alright, I fixed the lock file location and switched to creating "/var/run/tinyproxy" during installation (instead of in the rc.d script)...

Loading...