FS#27780 - PKGBUILD where exists a '++' couldn't be parsed
Attached to Project:
Pacman
Opened by DaNiMoTh (DaNiMoTh) - Saturday, 31 December 2011, 11:50 GMT
Last edited by Dan McGee (toofishes) - Saturday, 11 February 2012, 22:04 GMT
Opened by DaNiMoTh (DaNiMoTh) - Saturday, 31 December 2011, 11:50 GMT
Last edited by Dan McGee (toofishes) - Saturday, 11 February 2012, 22:04 GMT
|
Details
Summary and Info:
makepkg in pacman 4.0.1, package_libxml++() isn't recognized as function. With makepkg 3.5.4 everything is fine. Steps to Reproduce: Download PKGBUILD of libxml++ [danimoth@jim trunk]$ makepkg /home/danimoth/archlinuxppc/svn/libxml++/trunk/PKGBUILD: line 22: package_libxml++(): command not found ==> ERROR: An unknown error has occurred. Exiting... |
This task depends upon
Closed by Dan McGee (toofishes)
Saturday, 11 February 2012, 22:04 GMT
Reason for closing: Fixed
Additional comments about closing: commit 31432edcbe4
Saturday, 11 February 2012, 22:04 GMT
Reason for closing: Fixed
Additional comments about closing: commit 31432edcbe4
The line that is failing is "source $BUILDSCRIPT". Manually doing that from the bash shell works fine.
Also, changing "package_libxml++() {" to "package_libxml++ () {" works.
commit 0e79802c0ac8453376d8c0f99629f5a3b499f571
Author: Dave Reisner <dreisner@archlinux.org>
Date: Sat Sep 3 22:24:27 2011 -0400
makepkg: use globs in place of regex
We seem to enjoy using bash regex capabilities, but never referencing
the result with BASH_REMATCH. Replace almost all regexes with equivalent
globs which are faster and functionally equivalent in these cases.
This enables the extglob shopt.
Signed-off-by: Dave Reisner <dreisner@archlinux.org>
Signed-off-by: Dan McGee <dan@archlinux.org>
It's not clear upstream will care about this since the name of the function isn't really considered valid.
bar (0.1 KiB)