FS#27590 - [virtualbox-source] gzip command in vboxbuild is missing parameter -f

Attached to Project: Community Packages
Opened by Heiko Baums (cyberpatrol) - Friday, 16 December 2011, 02:11 GMT
Last edited by Ionut Biru (wonder) - Monday, 19 December 2011, 17:35 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Ionut Biru (wonder)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
When running vboxbuild I regularly get the following messages and particular questions by gzip:

# vboxbuild
:: Unloading VirtualBox kernel modules [DONE]
:: Removing all old VirtualBox kernel modules [FAIL]
:: Removing all old VirtualBox kernel modules [FAIL]
:: Recompiling VirtualBox kernel modules (3.1.5-1-fbcondecor) [BUSY]
gzip: /lib/modules/3.1.5-1-fbcondecor/extramodules/vboxdrv.ko.gz already exists; do you wish to overwrite (y or n)? y
gzip: /lib/modules/3.1.5-1-fbcondecor/extramodules/vboxnetadp.ko.gz already exists; do you wish to overwrite (y or n)? y
gzip: /lib/modules/3.1.5-1-fbcondecor/extramodules/vboxnetflt.ko.gz already exists; do you wish to overwrite (y or n)? y
gzip: /lib/modules/3.1.5-1-fbcondecor/extramodules/vboxpci.ko.gz already exists; do you wish to overwrite (y or n)? y
[DONE]
:: Reloading VirtualBox kernel modules [DONE]

If I run vboxbuild I usually want to get the modules rebuilt even if I have forgotten that I already rebuilt them after a kernel update. And it won't do any harm if previously built modules are overwritten by the new ones, because they wouldn't differ anyway if they already have been rebuilt.

So it would be nice if the parameter -f could be added to the gzip command in /usr/bin/vboxbuild to force the overwrite and to avoid those questions from gzip:
- gzip -9 "$MODULE_DIR"/*.ko
+ gzip -f9 "$MODULE_DIR"/*.ko
This task depends upon

Closed by  Ionut Biru (wonder)
Monday, 19 December 2011, 17:35 GMT
Reason for closing:  Fixed
Additional comments about closing:  virtualbox 4.1.8
Comment by Ionut Biru (wonder) - Friday, 16 December 2011, 07:54 GMT
what is wrong there is the cleanup not the gzip.
Comment by Heiko Baums (cyberpatrol) - Friday, 16 December 2011, 12:38 GMT
The cleanup, if you mean the removing of the old VirtualBox kernel modules with it, doesn't seem to work as you can see in the vboxbuild output. I don't know if this completely doesn't work or if this only removes modules for older major versions of the kernel.

Nevertheless I always are asked by gzip if I want to overwrite the old kernel modules which is really annoying since I want to have the rebuild done in the background (on a different console) without permanently watching and interacting with it. Adding the -f flag to gzip fixes it.

Loading...