FS#27485 - [namcap] warn on unstripped files

Attached to Project: Arch Linux
Opened by Jason William Walton (jasonww) - Wednesday, 07 December 2011, 19:01 GMT
Last edited by Eli Schwartz (eschwartz) - Friday, 07 July 2017, 19:14 GMT
Task Type Feature Request
Category Arch Projects
Status Closed
Assigned To Rémy Oudompheng (remyoudompheng)
Architecture All
Severity Low
Priority Normal
Reported Version 4.0.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Namcap should warn when it finds unstripped binary files.


Original report:
[makepkg] Don't check write permissions for strip

find . -type f -perm -u+w 2>/dev/null | while read binary ; do

The -perm conditional should be removed.

A good example is the perl package that ships every *.so file unstripped.

Either that or change namcap to mention unstripped files.

This task depends upon

Closed by  Eli Schwartz (eschwartz)
Friday, 07 July 2017, 19:14 GMT
Reason for closing:  Fixed
Additional comments about closing:  https://git.archlinux.org/namcap.git/com mit/?id=f73bf160de19e43d1c22a3db0f32b234 b872963f
Comment by Dan McGee (toofishes) - Thursday, 22 December 2011, 01:21 GMT
I'm voting this as a "won't fix". The proper solution would be to mark your files via chmod or proper install parameters as 755, not 555. We are trying to honor the unset write bit by not touching them.
Comment by Jason William Walton (jasonww) - Thursday, 22 December 2011, 06:15 GMT
There is nothing to honor, the build is guaranteed to fail without the conditional assuming that files that should be stripped are not writable.

Its just a ... less nice version of telling people to not ship unstripped stuff when not explicitly requested.

Anyway, Namcap will do just fine.
Comment by Allan McRae (Allan) - Sunday, 25 December 2011, 07:07 GMT
I also a "won't fix" as far a makepkg is concerned. I see this as respecting upstreams choice in installing those files with 555 permissions for some reason. I would accept a patch that caused makepkg to output a warning when it strikes a file it wants to strip but can't due to write permissions.

Changing this bug to a namcap feature request...
Comment by Jelle van der Waa (jelly) - Wednesday, 30 October 2013, 10:49 GMT
Ok I just implemented this feature in namcap. It was actually pretty easy with elfutils. Example output and patch is attached.
Comment by Kyle Keen (keenerd) - Friday, 07 July 2017, 19:06 GMT
Fixed by Jelle in commit f73bf16

Loading...