FS#27430 - [makepkg] make compression configurable

Attached to Project: Pacman
Opened by Christian Hesse (eworm) - Saturday, 03 December 2011, 14:47 GMT
Last edited by Allan McRae (Allan) - Friday, 09 March 2012, 05:36 GMT
Task Type Feature Request
Category makepkg
Status Closed
Assigned To Allan McRae (Allan)
Dave Reisner (falconindy)
Architecture All
Severity Low
Priority Normal
Reported Version 4.0.1
Due in Version 4.1.0
Due Date Undecided
Percent Complete 100%
Votes 3
Private No

Details

I would like to have an option to change compression parameters.
It could be a great benefit changing bz2 compression to pbzip2 or adding "-T 0" to latest xz from git for parallel compression.
   makepkg-config-compress.diff (2.2 KiB)
This task depends upon

Closed by  Allan McRae (Allan)
Friday, 09 March 2012, 05:36 GMT
Reason for closing:  Implemented
Additional comments about closing:  http://projects.archlinux.org/pacman.git /commit/?id=09a93b2e
Comment by Dave Reisner (falconindy) - Saturday, 03 December 2011, 17:44 GMT
I support this idea. I don't support embedding commands in strings, though (arrays should be used).
Comment by Christian Hesse (eworm) - Saturday, 03 December 2011, 23:19 GMT
How about this one? File extensions and commands are in array now.
   makepkg-config-compress.diff (3 KiB)
Comment by Dave Reisner (falconindy) - Saturday, 03 December 2011, 23:27 GMT
Not what I had in mind, as it doesn't actually address the concern I have. Was thinking of something more like...

COMPRESSGZ=(gzip -c -f -n)
COMPRESSBZ2=(bzip2 -c -f)
COMPRESSXZ=(xz -c -z -)
COMPRESSZ=(compress -c -f)
Comment by Christian Hesse (eworm) - Saturday, 03 December 2011, 23:46 GMT
What concerns do you have with strings (and my second solution, which is just strings in array...)?
Comment by Christian Hesse (eworm) - Saturday, 03 December 2011, 23:48 GMT
More like this?
   makepkg-config-compress.diff (2.2 KiB)
Comment by Dave Reisner (falconindy) - Saturday, 03 December 2011, 23:49 GMT
It's impossible to correctly quote a command which is embedded in a string.

http://mywiki.wooledge.org/BashFAQ/050

While there's no immediate need for it, I'd rather not leave ourselves open to mischief in the future should the need arise for... whatever..

...and the point of using arrays is lost if you do not properly quote the expansion

<snip>
*tar.gz) "${COMPRESSGZ[@]}" ;;
</snip>
Comment by Karol Błażewicz (karol) - Sunday, 04 December 2011, 09:52 GMT
Would using XZ_OPT environment variable work?
Comment by Christian Hesse (eworm) - Sunday, 04 December 2011, 10:08 GMT
Ah, I see...
   makepkg-config-compress.diff (2.2 KiB)
Comment by Christian Hesse (eworm) - Sunday, 04 December 2011, 14:58 GMT
Ups, found a typo in my brackets...
   makepkg-config-compress.diff (2.2 KiB)
Comment by Christian Hesse (eworm) - Monday, 05 December 2011, 09:19 GMT
A little enhancement... I added hardcoded fallbacks to makepkg. Now it does not fail if the arrays in /etc/makepkg.conf are not set.
   makepkg-config-compress.diff (2.2 KiB)
Comment by Christian Hesse (eworm) - Thursday, 15 December 2011, 22:11 GMT
Any news on this?

BTW, what does the last dash for xz do? Standard output is enabled via -c.
Comment by Allan McRae (Allan) - Saturday, 11 February 2012, 09:49 GMT
Added documentation and sent to pacman-dev for final comments: http://mailman.archlinux.org/pipermail/pacman-dev/2012-February/015103.html

Loading...