FS#27225 - [ngrep] ipv6 support broken

Attached to Project: Community Packages
Opened by Geert Hendrickx (ghen) - Tuesday, 22 November 2011, 10:46 GMT
Last edited by Lukas Fleischer (lfleischer) - Saturday, 25 February 2012, 12:08 GMT
Task Type Bug Report
Category Upstream Bugs
Status Closed
Assigned To Lukas Fleischer (lfleischer)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
ngrep incorrectly calculates the payload size for ipv6 packets, therefor doesn't display ipv6 packets correctly (hash marks only, no text).

Steps to reproduce:
There's a patch in the following Ubuntu bugreport which fixes the problem for me:

https://bugs.launchpad.net/ubuntu/+source/ngrep/+bug/567286

--- PKGBUILD 2011-11-22 06:14:52.000000000 +0100
+++ PKGBUILD 2011-11-22 11:40:42.481768322 +0100
@@ -13,12 +13,14 @@
depends=('libpcap>=1.0.0')
# Fix build failure when using "-j" ( FS#27091 ).
options=(!makeflags)
-source=("http://downloads.sourceforge.net/sourceforge/${pkgname}/${pkgname}-${pkgver}.tar.bz2")
-md5sums=('bc8150331601f3b869549c94866b4f1c')
+source=("http://downloads.sourceforge.net/sourceforge/${pkgname}/${pkgname}-${pkgver}.tar.bz2" "ngrep-fix-ipv6-support.patch")
+md5sums=('bc8150331601f3b869549c94866b4f1c'
+ 'b2ee6bdfeca1019eed4ba8392d2a63bb')

build() {
cd "${srcdir}/${pkgname}-${pkgver}"

+ patch -p1 -i "$srcdir/ngrep-fix-ipv6-support.patch"
./configure --prefix=/usr --with-pcap-includes=/usr/include/pcap --enable-ipv6
make
}

Please consider including this.
This task depends upon

Closed by  Lukas Fleischer (lfleischer)
Saturday, 25 February 2012, 12:08 GMT
Reason for closing:  Fixed
Additional comments about closing:  Fixed in 1.45-9.
Comment by Lukas Fleischer (lfleischer) - Wednesday, 23 November 2011, 14:53 GMT
I'd really like to see this being applied upstream. We usually do not patch sources, unless absolutely necessary. Given that ngrep is dead, there's isn't too much hope...
Comment by Geert Hendrickx (ghen) - Wednesday, 23 November 2011, 14:59 GMT
Since ipv6 support has only recently been enabled in the Arch ngrep package (ver 1.45-6), I think it only makes sense to have it actually working, rather than broken.

And since you mentioned upstream is dead, patching locally seems like to only option for now...
Comment by Lukas Fleischer (lfleischer) - Wednesday, 23 November 2011, 15:05 GMT
Adding a patch is one possible solution, moving ngrep to [unsupported] is the other. I'm fine with adding one patch, as long as this doesn't get out of hand...
Comment by Geert Hendrickx (ghen) - Wednesday, 23 November 2011, 15:18 GMT
Ok.
Comment by Jason William Walton (jasonww) - Wednesday, 30 November 2011, 04:15 GMT
Here is a patch that includes the ipv6 fix and also adds a patch that makes sure that system pcre is used instead of a local copy of pcre/regex: http://sprunge.us/FHRX
Comment by Jelle van der Waa (jelly) - Tuesday, 07 February 2012, 18:47 GMT
Should be fixed in 1.45-8.
Comment by Lukas Fleischer (lfleischer) - Thursday, 09 February 2012, 20:12 GMT
Patched version is in [community-testing] now.
Comment by Jason William Walton (jasonww) - Sunday, 12 February 2012, 15:00 GMT
The correct patches are not applied.

For convenience:

PKGBUILD: http://sprunge.us/GHSD
PCRE patch: http://sprunge.us/XAGA
IPv6 patch: http://sprunge.us/FCIB
Comment by Lukas Fleischer (lfleischer) - Saturday, 25 February 2012, 02:54 GMT
Yeah. I have no idea what Jelle did here. Blame him! :p Should be fixed in 1.45-9.
Comment by Geert Hendrickx (ghen) - Saturday, 25 February 2012, 09:03 GMT
Confirmed, thanks!

Loading...