Issue tracker moved to https://gitlab.archlinux.org/archlinux/aurweb/-/issues
FS#2710 - source files not separated by space
Attached to Project:
AUR web interface
Opened by Lyle Putnam (putz) - Friday, 06 May 2005, 22:06 GMT
Last edited by Simo Leone (neotuli) - Saturday, 07 May 2005, 13:16 GMT
Opened by Lyle Putnam (putz) - Friday, 06 May 2005, 22:06 GMT
Last edited by Simo Leone (neotuli) - Saturday, 07 May 2005, 13:16 GMT
|
DetailsIn a PKGBUILD file in the source array, if a line is escaped with a '\' character, the source files will appear as one in the "Files" listbox in Package Details View
|
This task depends upon
Closed by Simo Leone (neotuli)
Saturday, 11 June 2005, 03:38 GMT
Reason for closing: Deferred
Additional comments about closing: If we have more problems, we'll fix it, but for now, our evaluation is "close enough" to what bash does.
Saturday, 11 June 2005, 03:38 GMT
Reason for closing: Deferred
Additional comments about closing: If we have more problems, we'll fix it, but for now, our evaluation is "close enough" to what bash does.
noip.tar.gz
The problem was the source line, it was like so:
source=("http://www.no-ip.com/client/linux/$pkgname-duc-linux.tar.gz"\
"noip2-conffile.diff" "noip2")
I changed it like so:
source=("http://www.no-ip.com/client/linux/$pkgname-duc-linux.tar.gz" \
"noip2-conffile.diff" "noip2")
Notice the only difference here is a space before the backslash, and this works fine. So for the time being, please modify your pkgbuild.
I admit that our parser probably should know this (we don't actually use bash to evaluate these), since bash doesn't choke on it, either should our parser. It's goin on the todo list ;)
The little bugger's at line 194 of pkgsubmit.php, basically the problem here is that bash was evaluating it fine because there was whitespace on the next line, when I tried it in bash without whitespace on the next line, it behaved the same as the AUR did. The aur trims all the whitespace when it reads the line, but later on it goes using explode() along spaces to separate the sources.
We could possibly change around where some of the trimming is taking place... hmmm