FS#26701 - [pacman] makepkg should allow overriding BUILDENV easily

Attached to Project: Pacman
Opened by Mantas Mikulėnas (grawity) - Monday, 31 October 2011, 20:43 GMT
Last edited by Allan McRae (Allan) - Tuesday, 27 November 2012, 06:10 GMT
Task Type General Gripe
Category General
Status Closed
Assigned To Allan McRae (Allan)
Architecture All
Severity Very Low
Priority Normal
Reported Version 4.0.3
Due in Version 4.1.0
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Currently, makepkg's in_opt_array() function stops at the first matching option in BUILDENV, and if I want to override an option with ~/.makepkg.conf, I have to use:

BUILDENV=(sign distcc "${BUILDENV[@]}")

It would be better if it used the last match instead, allowing simpler assignments:

BUILDENV+=(sign distcc)
   0001-makepkg-use-the-last-res... (1.1 KiB)
This task depends upon

Closed by  Allan McRae (Allan)
Tuesday, 27 November 2012, 06:10 GMT
Reason for closing:  Implemented
Additional comments about closing:  https://projects.archlinux.org/pacman.gi t/commit/?id=fbf96203
Comment by Dave Reisner (falconindy) - Wednesday, 02 November 2011, 01:33 GMT
Reassigning to the correct project.
Comment by Allan McRae (Allan) - Thursday, 13 September 2012, 06:44 GMT
@Dave: does that patch look fine to you? The BUILDENV array is never large so I don't see an issue.
Comment by Allan McRae (Allan) - Monday, 17 September 2012, 07:05 GMT
Old patch is old... and no longer applies. New version sent to the mailing list.

Loading...