FS#26687 - [schroot] Improvements to the config files shipped

Attached to Project: Community Packages
Opened by Shanto (Shanto) - Sunday, 30 October 2011, 13:00 GMT
Last edited by Sergej Pupykin (sergej) - Monday, 21 November 2011, 13:52 GMT
Task Type Feature Request
Category Packages
Status Closed
Assigned To Sergej Pupykin (sergej)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

I would like to suggest some improvements to config files shipped with this package.

1. Remove "priority" key from the Arch32 section in schroot.conf which is deprecated. (W: line 78 [Arch32]: Deprecated key ‘priority’ used I: This option will be removed in the future; please update your configuration)
2. Move Arch32 scripts (/etc/schroot/{copyfiles,mount,script}-arch32) into a folder, likely /etc/schroot/arch32/.
3. Remove or comment out the Arch32 section. Or better, ship an inactive /etc/schroot/chroot.d/arch32.conf(.example) only.
4. Rename arch32-script to arch32/config, like other profiles in there.
This task depends upon

Closed by  Sergej Pupykin (sergej)
Monday, 21 November 2011, 13:52 GMT
Reason for closing:  Implemented
Additional comments about closing:  thanks
Comment by Shanto (Shanto) - Sunday, 30 October 2011, 21:45 GMT
@sergej My patch is not perfect - I posted it only for giving you a better idea; Don't apply it as-is. I am still working on minor changes such as fixing relative/absolute paths references and setting up pacman cache directory in arch32/fstab. I will come back to you with my final changes if you are interested to apply my ideas.
Comment by Shanto (Shanto) - Tuesday, 15 November 2011, 20:27 GMT
Applied all improvements mentioned above, plus:

1. Patch /etc/pam.d/schroot and remove Debian specific @include lines.
2. Add missing nssdatabases files. (/etc/schroot/arch32/nssdatabases)
3. Prefer inactive by default arch32.conf (/etc/schroot/chroot.d/arch32.conf.example).
4. Minor cosmetic fixes to current PKGBUILD.

Loading...