If the abs cannot fill the mirrorlist array, it returns the following:


==> Downloading tarballs...
==> core...
/usr/bin/abs: line 183: [: -ne: unary operator expected
tar (child): core.abs.tar.gz: Cannot open: No such file or directory
tar (child): Error is not recoverable: exiting now
tar: Child returned status 2
tar: Error is not recoverable: exiting now

instead of what it should:


==> Downloading tarballs...
==> core...
==> ERROR: Download failed
==> extra...
==> ERROR: Download failed
==> community...
==> ERROR: Download failed
==> multilib...
==> ERROR: Download failed

The reason for this is that the local variable "ret" is created, but never assigned a value, if the for loop that steps through the mirrorlist never runs, i.e. the mirrorlist is empty. After the for loop, ret is tested and, because it has no value, abs throws the above error.

Either ret should be assigned a value right off the bat (not 0, as that would defeat the download failure test) or the download failure test should be "if [ -z $ret ] || [ $ret -ne 0 ]".