FS#26306 - [aif] aif -p partial-configure-network cant find any interface

Attached to Project: Release Engineering
Opened by edac val (edacval) - Thursday, 06 October 2011, 20:12 GMT
Last edited by Dieter Plaetinck (Dieter_be) - Friday, 23 December 2011, 14:31 GMT
Task Type Bug Report
Category AIF
Status Closed
Assigned To Dieter Plaetinck (Dieter_be)
Architecture All
Severity Critical
Priority Normal
Reported Version testbuild (specify!)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

AIF can not find any network interface, because of changes to "ifconfig-a" output format after net-tools updated to version 1.60.20110819cvs-1.
Line 789 " ifaces=$(ifconfig -a |grep "Link encap:Ethernet"|sed 's/ \+Link encap:Ethernet \+HWaddr \+/ /g') " in /usr/lib/aif/core/libs/lib-ui-interactive.sh does not work anymore.

ifconfig -a output: http://pastebin.com/dPvTB4Tp
This task depends upon

Closed by  Dieter Plaetinck (Dieter_be)
Friday, 23 December 2011, 14:31 GMT
Reason for closing:  Fixed
Comment by edac val (edacval) - Thursday, 06 October 2011, 23:29 GMT
patch with workaround
   FS_26306.patch (1.4 KiB)
Comment by Ionut Biru (wonder) - Wednesday, 16 November 2011, 11:19 GMT
patch that implements fully the iproute2 syntax
   0001-lib-ui-interactive-revam... (3.2 KiB)
Comment by Ionut Biru (wonder) - Wednesday, 16 November 2011, 11:28 GMT
fix indentation
   0001-lib-ui-interactive-revam... (3.2 KiB)
Comment by Dieter Plaetinck (Dieter_be) - Thursday, 17 November 2011, 13:46 GMT
indentation still not okay..

Comment by Ionut Biru (wonder) - Thursday, 17 November 2011, 14:07 GMT
fix them all for good
   0001-lib-ui-interactive-revam... (3.2 KiB)
Comment by Dieter Plaetinck (Dieter_be) - Thursday, 15 December 2011, 10:05 GMT
real explanation:
14:40 < tomegun> Dieterbe: in short: ifconfig=unmaintained and iproute=the future
14:40 < tomegun> ifconfig will continue to work (probably forever), but it is officially deprecated and everyone is encouraged to use the iproute stuff

ifconfig is no longer in base.
net-tools is an ancient package (last released 10 years ago) that has been replaced by iptools2.
net-tools should no longer be in the iso's (it's not included in the releng configs)

iproute2 should be added to list of dependencies of AIF. (all distros should have it) and we should parse `ip` output.
Comment by Thomas Bächler (brain0) - Thursday, 15 December 2011, 14:04 GMT
Some of this stuff can be done more reliably by looking at /sys/class/net/ instead of parsing 'ip' or 'ifconfig' output.
Comment by Ionut Biru (wonder) - Monday, 19 December 2011, 15:30 GMT
new patch including the changes proposed by Thomas, including readme and documentation changes
   0001-revamp-for-iproute2-synt... (6.8 KiB)
Comment by Ionut Biru (wonder) - Monday, 19 December 2011, 17:14 GMT
fix the return in setting the gateway
   0002-Fix-return-condition.pat... (1 KiB)
Comment by Dieter Plaetinck (Dieter_be) - Friday, 23 December 2011, 14:30 GMT
both patches applied in develop branch, will be available for testing in next testbuild.
Although Ionut already did some testing, so I'll just close this.

thanks guys!

Loading...