AUR web interface

Tasklist

FS#2599 - Characters in package description get eaten

Attached to Project: AUR web interface
Opened by Leslie Polzer (skypher) - Sunday, 17 April 2005, 21:14 GMT
Last edited by Paul Mattal (paul) - Saturday, 11 June 2005, 04:19 GMT
Task Type Bug Report
Category Backend
Status Closed
Assigned To Paul Mattal (paul)
Architecture All
Severity Low
Priority Normal
Reported Version 1.0
Due in Version 1.1.1
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

The description text for kguitar reads:

"Guitarist's tool"

but in AUR the single quote is gone.
May occur with other characters, perhaps someone should check.
   bug2599.diff (0.8 KiB)
This task depends upon

Closed by  Paul Mattal (paul)
Tuesday, 01 August 2006, 04:43 GMT
Reason for closing:  Fixed
Additional comments about closing:  in r286
now removes " or ' from pkgdesc only if they form a start/end pair
Comment by Simo Leone (neotuli) - Monday, 18 April 2005, 03:21 GMT
This currently occurs by design around line 230 of pkgsubmit.php .

The attached patch keeps the current behavior for all lines other than pkgdesc. In the case of pkgdesc, it strips off any leading or ending single or double quotes, using php's trim(), which leaves any parentheses as well as quotes within the actual description intact.
Comment by Paul Mattal (paul) - Thursday, 09 June 2005, 21:09 GMT
Re-opened per request: what's up?
Comment by Leslie Polzer (skypher) - Thursday, 09 June 2005, 21:17 GMT
Still a problem with the single quotes, please take a look at package 'ncc' - the description in the PKGBUILD is

"'ncc' is aC source code analyzer which generates program flow and variable usage information"

but the first quote is gone in AUR.
Comment by Simo Leone (neotuli) - Thursday, 09 June 2005, 22:10 GMT
Well the way the fix gets around the problem is by only stripping things from the ends. For our purposes, we need to strip off the double quotes, but they could just as well be single quotes, bash wouldn't care, it would evaluate just as well, so we can't necessarily distinguish.
I'd suggest you change the package rather than us trying to write the complicated algorithm needed to do it in the AUR, unless, of course, you would like to take a stab at it yourself. :)
Comment by Leslie Polzer (skypher) - Thursday, 09 June 2005, 22:14 GMT
Wouldn't stripping only the outermost level of quotes be a solution?
Comment by Paul Mattal (paul) - Friday, 10 June 2005, 04:30 GMT
There's got to be an ugly regexp that will solve this problem. I'll give it some thought. ;)
Comment by Simo Leone (neotuli) - Friday, 10 June 2005, 15:16 GMT
I've found kregexpeditor helpful :)
Comment by Simo Leone (neotuli) - Friday, 12 August 2005, 04:24 GMT
why is this one reopened?
Comment by Paul Mattal (paul) - Thursday, 18 August 2005, 15:19 GMT
It's reopened because we didn't really get it right. We need a more complex regexp or some other form of processing.

Loading...