FS#25972 - [archlinux-xdg-menu] xdg_menu fails to find some icons

Attached to Project: Community Packages
Opened by Olivier (olive) - Monday, 12 September 2011, 07:43 GMT
Last edited by Sergej Pupykin (sergej) - Monday, 12 September 2011, 08:57 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Sergej Pupykin (sergej)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

xdg_menu fails to find some icons, for example the xpdf one. I have figured out what happens. The xpdf icon is referenced in the desktop file as xpdf and the corresponding icon is /usr/share/pixmaps/xpdf.xpm.

xdg_menu proceeds the following way:

1) it add_png_extension_if_needed, if needed for it means "there is no extension in the icon referenced in the desktop file; this gives xpdf.png

2) Now at line 138, it will looks at the following filenames (in the correct directories): xpdf.png, xpdf.png.png, xpdf.png.xpm

This does not gives the xpdf.xpm icon.

I attach a patch that fix the problem.


Additional info:
* package version(s)
0.7.5.1-1
* config and/or log files etc.


Steps to reproduce:

xdg_menu --format icewm --fullmenu --root-menu /etc/xdg/menus/arch-applications.menu > ~/.icewm/menu
   xdg_menu.patch (1.8 KiB)
This task depends upon

Closed by  Sergej Pupykin (sergej)
Monday, 12 September 2011, 08:57 GMT
Reason for closing:  Implemented
Additional comments about closing:  thanks
Comment by Olivier (olive) - Monday, 12 September 2011, 07:53 GMT
An additional problem is that it fails to find absolute referenced icons, for example the twinkle one, referenced as /usr/share/twinkle/twinkle48.png. I think a simple way to solve it is to put / at the beginning of the @icon_search_path

Loading...