FS#25887 - [firefox/thunderbird] !buildflags and hardcoded LDFLAGS.

Attached to Project: Arch Linux
Opened by Sverd Johnsen (sjohnsen) - Sunday, 04 September 2011, 14:06 GMT
Last edited by Jan Alexander Steffens (heftig) - Saturday, 01 October 2011, 11:22 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Ionut Biru (wonder)
Jan Alexander Steffens (heftig)
Architecture All
Severity Very Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Currently, in both Firefox and Thunderbird !buildflags is set.

I think this was done because the mozilla build changes optimization levels troughout the build so our flags C(XX)FLAGS wouldn't interfere with them.

The problem is that this not only effectively removes any and all user chosen flags but also the official ones. I suggest filtering out -O2 from the flags explicitly and removing the !buildflags option.

In addition the LDFLAGS are hardcoded. This can be fixed too now that makepkg.conf ships with new LDFLAGS by default - RPATH obviously still needs to be set.
This task depends upon

Closed by  Jan Alexander Steffens (heftig)
Saturday, 01 October 2011, 11:22 GMT
Reason for closing:  Fixed
Additional comments about closing:  Fixed in trunk.
Comment by Ionut Biru (wonder) - Sunday, 04 September 2011, 14:09 GMT
how can you see that !buildflags unsets the official flags as well?

i'm looking into about:buildconfig
Comment by Sverd Johnsen (sjohnsen) - Sunday, 04 September 2011, 14:13 GMT
Oh, I mean the default Arch Linux flags. Sorry for the confusion.
Comment by Ionut Biru (wonder) - Sunday, 04 September 2011, 14:16 GMT
that's the idea. we want to unset build flags to not interfere with mozilla ones. They apply some optimization to pgo and we won't want to break them
Comment by Sverd Johnsen (sjohnsen) - Sunday, 04 September 2011, 14:19 GMT
Except that to my knowledge it doesn't break anything. Their build will gladly take our flags and work with them. As long as we unset -O2 it should be alright. I'm not sure if things changed in 6.0, but everywhere before that It used to work just fine.
Comment by Ionut Biru (wonder) - Sunday, 04 September 2011, 14:21 GMT
before introducing the !buidflags, we were unset-ing them manually in PKGBUILD for years.
Comment by Sverd Johnsen (sjohnsen) - Sunday, 04 September 2011, 14:38 GMT
Doesn't mean it was the right thing to do all the time ;)
Comment by Jan de Groot (JGC) - Monday, 05 September 2011, 14:02 GMT
I reverted this for nss and nspr two weeks ago. As for stripping out -O2: that's not even needed. The mozilla build system takes your flags and appends its own to that. If mozilla adds -Os behind our -O2, the compiler will take -Os. Same thing with -O3 and profiling stuff. IMHO we shouldn't need to unset CFLAGS/CXXFLAGS anymore.
Comment by Jan Alexander Steffens (heftig) - Tuesday, 06 September 2011, 00:38 GMT
I'm building my Aurora with buildflags (O2 replaced by O3 as per Mozilla suggestion), no problems.
Comment by Sverd Johnsen (sjohnsen) - Saturday, 01 October 2011, 08:55 GMT
  • Field changed: Percent Complete (100% → 0%)
LDFLLAGS are still hardcoded. Fix in staging for next build?

Loading...