FS#25827 - makepkg and .install files in pacman4

Attached to Project: Pacman
Opened by Jesse Jaara (Huulivoide) - Tuesday, 30 August 2011, 13:52 GMT
Last edited by Allan McRae (Allan) - Friday, 02 September 2011, 07:48 GMT
Task Type Bug Report
Category makepkg
Status Closed
Assigned To Allan McRae (Allan)
Architecture All
Severity Medium
Priority Normal
Reported Version git
Due in Version 4.0.0
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Summary and Info:
Apparently the way the install= variable in PKGBUILDs
has changed. Currently there are many PKGBUILDS in AUR
witch use syntax like

install='fluffy-theme.install'

But with makepkg from git it doesn't work,
instead of setting the .install file to that
what's inside '' it considers the ' marks to
be part of the filename. While there's no
reason to have charters that would require
" or 's in the filename, there's even less
need to have 's as part of the file name.

I don't know if this is intentional change or a bug.
But personally I think 's shouldn't matter.

Steps to Reproduce:
Try to build some package with '' in its
install= thingy, with git makepkg.
This task depends upon

Closed by  Allan McRae (Allan)
Friday, 02 September 2011, 07:48 GMT
Reason for closing:  Fixed
Additional comments about closing:  http://projects.archlinux.org/pacman.git /commit/?id=35d8cc8b
Comment by Dan McGee (toofishes) - Tuesday, 30 August 2011, 14:03 GMT
"Many" and you didn't link to a single example? Please help us out here...
Comment by Jesse Jaara (Huulivoide) - Tuesday, 30 August 2011, 14:05 GMT
https://aur.archlinux.org/packages.php?ID=51476
that is the latest I'w stumbled across
Comment by Dave Reisner (falconindy) - Tuesday, 30 August 2011, 17:15 GMT
known, i broke it. i fixed it:

https://github.com/falconindy/pacman/commit/247efd7a7fe7900df4b02b12395914afccbb2075
Comment by lorim (lorim) - Saturday, 08 October 2011, 08:11 GMT
it seems that lines like install=(name.install) are broken too. See e.g. https://aur.archlinux.org/packages.php?ID=32204
Comment by Dave Reisner (falconindy) - Saturday, 08 October 2011, 13:25 GMT
install and changelog are simple variables, not arrays. As far as I'm concerned, makepkg does the right thing by rejecting these.
Comment by lorim (lorim) - Saturday, 08 October 2011, 13:33 GMT
well, it is accepted in pacman 3.5, and some PKGBUILD are done this (wrong) way. probably is it not worth opening a bug for 3.5.4 ?
Comment by Allan McRae (Allan) - Sunday, 09 October 2011, 10:53 GMT
I'm 50/50 on this. I agree that they are not arrays so this is "right", but if the regex used to filter quotations can easily be adjusted to also deal with brackets, then I would have no issues adding it.
Comment by Dave Reisner (falconindy) - Sunday, 09 October 2011, 15:46 GMT
It's not a very involved change, but I'm 50/50 as well because I don't really like giving the impression that this is allowed, despite being valid bash and working, regardless.

http://sprunge.us/QPhD

edit: ^ that's busted. Real patch to be sent to the ML for bike shedding and name calling.

Loading...