FS#25790 - [archboot] some BINARIES should be FILES in some hook

Attached to Project: Arch Linux
Opened by Liu Dongiao (liudongmiao) - Saturday, 27 August 2011, 15:48 GMT
Last edited by Tobias Powalowski (tpowa) - Monday, 29 August 2011, 14:09 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Tobias Powalowski (tpowa)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
when these files (most shell script) are in BINARIES, then mkinitcpio will try to ldd, and return 1.
then after the mkinitcpio, these lines are displays:
errors were encountered during the build. The image may not be complete.

I'd like to fix it....

Additional info:
archboot 2011.08-2
mkinitcpio 0.7.2-1

Steps to reproduce:
1. add one of arch_base, arch_filesystems, arch_hwdetect, arch_net, arch_pciutils, arch_shadow to config file
2. run mkinitcpio -c /path/to/config -g /path/to/image, it will display "errors were ..."

I have written a patch to fix it (for git version), you can get it from http://thom.nklog.org/tmp/archboot.diff

Another question..of course, can be ignored.
python is not required in arch_net, why the python LICENSE is required?
This task depends upon

Closed by  Tobias Powalowski (tpowa)
Monday, 29 August 2011, 14:09 GMT
Reason for closing:  Fixed
Additional comments about closing:  on git tree
Comment by Dave Reisner (falconindy) - Saturday, 27 August 2011, 16:18 GMT
There's perhaps just as strong of an argument to fix this in mkinitcpio... The add_binary function will always add the file you tell it to add, but I'm not sure it "does the right thing" by returning an error when ldd shows that its not a dynamically linked ELF.
Comment by Liu Dongiao (liudongmiao) - Sunday, 28 August 2011, 02:18 GMT
and the mkinitcpio will say, there is api add_binary and add_file.. why not use add_file for a shell script?
of course, mkinitcpio or archboot, should fix it... but in my opinion, it's the duty of archboot, not mkinitcpio.

another question, do you know why python LICENSE in arch_wireless? (sorry for the typo in the bug)
Comment by Tobias Powalowski (tpowa) - Monday, 29 August 2011, 14:09 GMT
fixed thanks.

Loading...