Arch Linux

Thanks for the reminder. I have pushed a commit here: <https://github.com/teg/mkinitcpio/commit/d7714d5c2e608230c19d63875bbeb7022d9b7f69>.

One thing to check before committing: How does add_file deal with missing files? In the future the /etc/modprobe.d/<...> file may or may not exist. Will it just be silently ignored if I try to add a non-existent file? Should it be?

It complains about missing files:

https://github.com/falconindy/mkinitcpio/blob/master/functions#L233

If you add a file and it doesn't exist, you should be told as such.

I don't know what is best: adding just the /lib file will not cause any warnings, but is strictly speaking "wrong" as the user should be able to override it in /etc. That said, I cannot imagine why anyone would override this file...

What about that?
[ -f "/etc/modprobe.d/usb-load-ehci-first.conf" ] && add_file "/etc/modprobe.d/usb-load-ehci-first.conf" || add_file "/lib/modprobe.d/usb-load-ehci-first.conf"

or

if [ -f "/etc/modprobe.d/usb-load-ehci-first.conf" ]; then
__add_file "/etc/modprobe.d/usb-load-ehci-first.conf"
else
__add_file "/lib/modprobe.d/usb-load-ehci-first.conf"
fi

Sure, a conditional is the way to solve this. I don't think that needs to be pointed out here. However, neither of your solutions are satisfactory. For your own edification:

- we use bash, not posix constructs in mkinitcpio
- there are undesirable side effects when using a compound command (especially in this case)
- we should be looking explicitly for the rule in /lib first, not /etc.
- __add_file requires 3 parameters or else it will fail. moreover, it should never be used by build-time hooks. add_file is much smarter.

I used the underscores only for indentation as spaces don't work, didn't realize this other function also exists.

Did this in one fell swoop. No kludges, just a hard dep on the new filesystem package.