FS#25749 - makepkg -i gives wrong errorcode

Attached to Project: Pacman
Opened by guido (qqqqqqqqq9) - Thursday, 25 August 2011, 00:01 GMT
Last edited by Allan McRae (Allan) - Thursday, 08 September 2011, 00:42 GMT
Task Type Bug Report
Category makepkg
Status Closed
Assigned To Allan McRae (Allan)
Architecture All
Severity Low
Priority Normal
Reported Version 3.5.3
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
makepkg -i gives errorcode 0 on failure instead of 1.

From /usr/bin/makepkg:

1207 if ! run_pacman -U $pkglist; then
1208 warning "$(gettext "Failed to install built package(s).")"
1209 return 0
1210 fi

Additional info:
* package version(s)
* config and/or log files etc.


Steps to reproduce:
This task depends upon

Closed by  Allan McRae (Allan)
Thursday, 08 September 2011, 00:42 GMT
Reason for closing:  Won't fix
Additional comments about closing:  See comments
Comment by Allan McRae (Allan) - Thursday, 25 August 2011, 04:05 GMT
This is deliberate. The decision was made a while back that makepkg had succeeded in its primary operation (to make the package) so it should return 0. That is why the output message there is a "warning" rather than an "error".
Comment by Allan McRae (Allan) - Thursday, 25 August 2011, 04:12 GMT
Commit: http://projects.archlinux.org/pacman.git/commit/?id=deff57ce

Loading...