AUR web interface

Tasklist

FS#25693 - [RPC] numeric fields should be numeric types in the reply JSON

Attached to Project: AUR web interface
Opened by Dave Reisner (falconindy) - Saturday, 20 August 2011, 22:45 GMT
Last edited by Lukas Fleischer (lfleischer) - Sunday, 04 November 2012, 11:45 GMT
Task Type General Gripe
Category Backend
Status Closed
Assigned To Lukas Fleischer (lfleischer)
Architecture All
Severity Low
Priority Normal
Reported Version 1.9.0
Due in Version 2.0.0
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

We've got 3 fields in the JSON reply that will never contain anything but numeric data: ID, FirstSubmitted, and LastModified. However, these are serialized as string types, forcing front ends to do conversion and validation. These should be packed as number types.

Yes, this breaks API. I wants it. My precioussss....

related gripe: Also, I can't assign this to 'reported version=1.9.0'.
This task depends upon

Closed by  Lukas Fleischer (lfleischer)
Sunday, 04 November 2012, 11:45 GMT
Reason for closing:  Fixed
Additional comments about closing:  Fixed in 2.0.0.
Comment by Lukas Fleischer (lfleischer) - Tuesday, 20 September 2011, 09:04 GMT
Right. As discussed on aur-dev, we should coerce "CategoryID", "NumVotes" and "OutOfDate" as well. I even thought of dropping "OutOfDate" and providing the "OutOfDateTS" field that we use internally instead?
Comment by Dave Reisner (falconindy) - Tuesday, 20 September 2011, 10:04 GMT
I think providing OutOfDateTS would be great. Is this field zeroed or emptied out in the case of the package being up to date?
Comment by Lukas Fleischer (lfleischer) - Tuesday, 20 September 2011, 10:35 GMT
Yeah, either zeroed out or set to null.
Comment by Lukas Fleischer (lfleischer) - Tuesday, 25 October 2011, 07:20 GMT
  • Field changed: Due in Version (Undecided → 2.0.0)
Fixed in master [1].

[1] http://projects.archlinux.org/aur.git/commit/?id=795971bc806776ad48de6f0135736cbaaefa5fcd

Loading...