Release Engineering

Tasklist

FS#25592 - choosen mirror not added to /etc/pacman.d/mirrorlist

Attached to Project: Release Engineering
Opened by Dieter Plaetinck (Dieter_be) - Monday, 15 August 2011, 22:04 GMT
Last edited by Dieter Plaetinck (Dieter_be) - Thursday, 18 August 2011, 18:46 GMT
Task Type Bug Report
Category AIF
Status Closed
Assigned To No-one
Architecture All
Severity High
Priority High
Reported Version testbuild (specify!)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

/etc/pacman.d/mirrorlist is untouched, so it actually always uses the kernel.org mirror.
however, it says "adding mirror blah to /etc/pacman.d/mirrorlist", so configure_mirrorlist is being executed from target_prepare_pacman

2011.08.15
This task depends upon

Closed by  Dieter Plaetinck (Dieter_be)
Thursday, 18 August 2011, 18:46 GMT
Reason for closing:  Fixed
Comment by Dieter Plaetinck (Dieter_be) - Tuesday, 16 August 2011, 07:36 GMT
fixed a bug in that code, if it goes wrong, should see warning now
Comment by Gerardo Exequiel Pozzi (djgera) - Tuesday, 16 August 2011, 14:17 GMT
A custom mirror is now ignored (not added to mirrorlist), using heads/develop-0-g0ce21ba

Select Source -> Custom
Comment by Dieter Plaetinck (Dieter_be) - Wednesday, 17 August 2011, 08:02 GMT
Any mirror you choose, won't be added to the mirrorlist. Well, I mean the mirrorlist at /etc/pacman.d/mirrorlist, which is the bug this ticket is about.
Are you talking about the same file, or /mnt/etc/pacman.d/mirrorlist?
Comment by Dieter Plaetinck (Dieter_be) - Wednesday, 17 August 2011, 08:28 GMT
And btw, this should fix it: https://github.com/Dieterbe/aif/commit/0ce21ba4e33ae4e00f5ff67e3ba4723a79e7f60b
except it doesn't.
In my logfile I see:
"DEBUG: PACMAN PROCEDURE Adding choosen mirror (ftp://mirrors.kernel.org/archlinux/$repo/os/$arch) to /etc/pacman.d/mirrorlist"
but yet, /etc/pacman.d/mirrorlist is unchanged. So the awk call below the debug call fails somehow.
Comment by Dieter Plaetinck (Dieter_be) - Wednesday, 17 August 2011, 10:30 GMT
okay, with help from Tucos on irc we noticed $file gets changed to /var/log/aif.log somewhere in that function (before the awk call)
i can probably fix the bug myself now pretty easily once i have some time
edit: ok, it's because of debug() in libui-sh, will push fix later.
Comment by Gerardo Exequiel Pozzi (djgera) - Wednesday, 17 August 2011, 15:17 GMT
I am talk about "Select Source -> Custom" that is not used for installing packages. I do not know what files are used for this.
Comment by Dieter Plaetinck (Dieter_be) - Wednesday, 17 August 2011, 15:23 GMT
okay then we're talking about the same thing. hold on I can easily fix this when I have some time
Comment by Dieter Plaetinck (Dieter_be) - Wednesday, 17 August 2011, 16:46 GMT
pushed fix to both libui-sh and aif git.
http://releng.archlinux.org/isos/ will contain a 2011.08.17 directory soon (in an hour or so), you can use those to retest
(moved the old 2011.08.17 to 2011.08.17-old)
Comment by Gerardo Exequiel Pozzi (djgera) - Wednesday, 17 August 2011, 21:24 GMT
Using http://releng.archlinux.org/repos/releng-any/aif-2011.08.17-1-any.pkg.tar.xz and http://releng.archlinux.org/repos/releng-any/libui-sh-2011.08.17-1-any.pkg.tar.xz

Still does not work.

"Select source" -> "custom" -> Entering: ftp://192.168.0.66/archlinux/core/os/i686

[root@archiso ~]# cat /tmp/pacman.conf
[options]
CacheDir = /mnt/var/cache/pacman/pkg
Architecture = auto

[core]
Include = /etc/pacman.d/mirrorlist
[root@archiso ~]# head /etc/pacman.d/mirrorlist
##
## Arch Linux repository mirrorlist
## Generated on 2011-08-14
##

## Any
Server = ftp://mirrors.kernel.org/archlinux/$repo/os/$arch
Server = http://mirrors.kernel.org/archlinux/$repo/os/$arch

## Australia
[root@archiso ~]#
Comment by Dieter Plaetinck (Dieter_be) - Wednesday, 17 August 2011, 21:30 GMT
hmm those packages don't contain the fix yet for some reason. can you check with the 2011.08.17 iso?
Comment by Gerardo Exequiel Pozzi (djgera) - Wednesday, 17 August 2011, 21:49 GMT
More quickly testing from git repo...

Using libui-sh-2010.08.19-16-gd833d9b and aif-2011.08.04-36-gb70d7db:

After welcome screen:

ERROR: ask option $4 must be required or optional or ''. not required
Comment by Dieter Plaetinck (Dieter_be) - Thursday, 18 August 2011, 11:42 GMT
should be fixed in http://releng.archlinux.org/isos/2011.08.18/
please confirm
Comment by Dieter Plaetinck (Dieter_be) - Thursday, 18 August 2011, 18:45 GMT
fixed in 2011.08.18

Loading...