FS#25451 - [linux] Inconsistency in PKGBUILD that affects custom kernels

Attached to Project: Arch Linux
Opened by buergi (buergi) - Monday, 08 August 2011, 09:59 GMT
Last edited by Tobias Powalowski (tpowa) - Wednesday, 17 August 2011, 06:25 GMT
Task Type General Gripe
Category Packages: Core
Status Closed
Assigned To Tobias Powalowski (tpowa)
Thomas Bächler (brain0)
Architecture All
Severity Very Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

There is a tiny inconsistency in the PKGBUILD of the linux package.
It does actually only matter for custom kernel builds.

The script changes the initramfs image paths in linux.preset but not the kernel image. I would suggest to add the following lines (at least the second one) to the corresponding section in the PKGBUILD.

# set correct depmod command for install
sed \
+ -e "1s|'linux'|'${pkgname}'|g" \
+ -e "s|ALL_kver=.*|ALL_kver=\"/boot/vmlinuz-${pkgname}\"|g" \
-e "s/KERNEL_NAME=.*/KERNEL_NAME=${_kernelname}/g" \

or when dirty ways are allowed perhaps even just
sed -e "s|linux|${pkgname}|g" (...)
This task depends upon

Closed by  Tobias Powalowski (tpowa)
Wednesday, 17 August 2011, 06:25 GMT
Reason for closing:  Duplicate
Comment by buergi (buergi) - Monday, 08 August 2011, 10:01 GMT
Hm ok you know what i mean, even when the bugtracker removed the spaces in front of the lines.
The + lines should be the new ones, just as in a diff patch.
Comment by Ionut Biru (wonder) - Monday, 08 August 2011, 10:11 GMT
provide a patch
Comment by Thomas Bächler (brain0) - Monday, 08 August 2011, 11:28 GMT
Yes, if you provide a diff, it will be much easier to understand. I agree that this should be adjusted to ease kernel customization.
Comment by Heiko Baums (cyberpatrol) - Monday, 08 August 2011, 17:27 GMT
For a patch see my duplicate  FS#25460 .
The part "+ -e "1s|'linux'|'${pkgname}'|g" \" is not necessary.

Tell me, if you want me to attach the patch here, too.
Comment by Ray Rashif (schivmeister) - Monday, 08 August 2011, 20:45 GMT
You can just attach your patch here, no harm.
Comment by Heiko Baums (cyberpatrol) - Monday, 08 August 2011, 21:16 GMT
Ok, here it is.
Comment by Heiko Baums (cyberpatrol) - Monday, 08 August 2011, 21:17 GMT
It's patched against the PKGBUILD in abs.

Loading...