FS#25425 - [aif] block device lists includes archiso's /dev/mapper devices

Attached to Project: Release Engineering
Opened by Dave Reisner (falconindy) - Saturday, 06 August 2011, 16:43 GMT
Last edited by Dieter Plaetinck (Dieter_be) - Wednesday, 17 August 2011, 20:27 GMT
Task Type Bug Report
Category AIF
Status Closed
Assigned To Dieter Plaetinck (Dieter_be)
Architecture All
Severity Low
Priority Normal
Reported Version 2010.05
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

During block device configuration, archiso's /dev/mapper devices are listed as possible options for manual configuration:

/dev/mapper/lib-modules
/dev/mapper/root-image
/dev/mapper/usr-share

These should be hidden
This task depends upon

Closed by  Dieter Plaetinck (Dieter_be)
Wednesday, 17 August 2011, 20:27 GMT
Reason for closing:  Fixed
Comment by Dieter Plaetinck (Dieter_be) - Thursday, 11 August 2011, 21:06 GMT
awaiting cleaner filenames in archiso. http://mailman.archlinux.org/pipermail/arch-releng/2011-August/001895.html
Comment by Dieter Plaetinck (Dieter_be) - Friday, 12 August 2011, 21:26 GMT
this should be fixed, see https://github.com/Dieterbe/aif/commit/bcb8612f6732ad75d919a5a822bb440ec00e3cf4
please test with testbuild 2011.08.13 or newer
Comment by Dave Reisner (falconindy) - Friday, 12 August 2011, 21:29 GMT
It's not fixed, what you committed is a syntax error.

$ set -s extglob
-bash: set: -s: invalid option
set: usage: set [-abefhkmnptuvxBCHP] [-o option-name] [--] [arg ...]

You meant to use shopt here instead. And why unset? extglobs are useful. You should just enable them at the top of the file.
Comment by Dieter Plaetinck (Dieter_be) - Friday, 12 August 2011, 21:33 GMT
oops.. pushed a fix.
I prefer to enable non-standard behavior only for the short time I actually need it, that way it's easier to understand unrelated code
Comment by Dieter Plaetinck (Dieter_be) - Wednesday, 17 August 2011, 20:09 GMT
can anyone confirm this is fixed?
Comment by Dave Reisner (falconindy) - Wednesday, 17 August 2011, 20:24 GMT
Confirmed, fixed.

Loading...