Community Packages

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#25414 - [gnubiff-gtk] [gnubiff] with-password-string configure option misused (and insecure anyway)

Attached to Project: Community Packages
Opened by Ray (ataraxia) - Friday, 05 August 2011, 21:50 GMT
Last edited by Sergej Pupykin (sergej) - Wednesday, 10 August 2011, 14:39 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Sergej Pupykin (sergej)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description:
The PKGBUILDs of gnubiff and gnubiff-gtk pass the options "--with-password --with-password-string" to configure. There are two problems with this:

1) --with-password-string is supposed to take an argument instead of being passed alone. Without this argument, all saved passwords are encrypted with the same password "FEDCBA9876543210", easily found by reading the configure script. With an argument, that string would be used instead, so that at least Arch users get a different encryption password than the rest of the world.

2) Even with a string being passed in, this is still terribly insecure since a stolen .gnubiffrc file would yield the user's mail password to anyone who can read our PKGBUILDs. Note that this software does not make password saving optional at runtime - as they are built today, it is MANDATORY to save any passwords typed in to disk. The only way to avoid saving them is to disable the capability of password saving entirely at compile time.

My recommendation: stop passing "--with-password --with-password-string" to configure. This will prevent any form of password saving on disk, requiring users to type them in again on each startup. A bit annoying perhaps, but the alternative of being required to save passwords insecurely to disk is worse.

If the previous recommendation is unacceptable, at least start building these packages with an argument passed to --with-password-string, for some minimal security gain.

Additional info:
* package version(s)
gnubiff-gtk 2.2.13-2
gnubiff 2.2.13-1
This task depends upon

Closed by  Sergej Pupykin (sergej)
Wednesday, 10 August 2011, 14:39 GMT
Reason for closing:  Fixed
Additional comments about closing:  built with --with-password-string="..."

Loading...