FS#25014 - Bug in /etc/rc.d/cups

Attached to Project: Arch Linux
Opened by Mark (voidzero) - Monday, 04 July 2011, 12:03 GMT
Last edited by Andreas Radke (AndyRTR) - Friday, 15 July 2011, 03:54 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Andreas Radke (AndyRTR)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

In this script add_daemon uses $daemon_name which has been set to cups. This is slightly incorrect. Although the name of the script itself is cups, the daemon name is cupsd. Therefore ck_daemon does not report the daemon as running (it is looking for cups while /run/daemons contains cupsd). This breaks the kill_everything routine because cupsd is not found -- cups only quits after shutdown sends a HUP and a TERM to all remaining devices.

Solution:
Rename /etc/rc.d/cups to cupsd (which I favorite for consistency) or change add_daemon/rm_daemon/chk_status's argument from $daemon_name to cups.
This task depends upon

Closed by  Andreas Radke (AndyRTR)
Friday, 15 July 2011, 03:54 GMT
Reason for closing:  Fixed
Additional comments about closing:  typo fixed in trunk for future builds.
Comment by Mark (voidzero) - Monday, 04 July 2011, 12:04 GMT
One typo in the first line: add_daemon uses $daemon_name which has been set to cupsd. Not cups.
Comment by David J. Haines (dhaines) - Thursday, 14 July 2011, 12:59 GMT
This also affects the output of "rc.d list" which thinks that cups isn't running when it really is.
Comment by Andreas Radke (AndyRTR) - Thursday, 14 July 2011, 15:35 GMT
So line 108 in the PKGBUILD
install -D -m755 ../cups ${pkgdir}/etc/rc.d/cups
should be changed to
install -D -m755 ../cups ${pkgdir}/etc/rc.d/cupsd ?


Comment by David J. Haines (dhaines) - Thursday, 14 July 2011, 15:47 GMT
Andreas: That seems to fix it. People will need to update their DAEMONS line in /etc/rc.conf accordingly.
Comment by Dan McGee (toofishes) - Thursday, 14 July 2011, 21:16 GMT
Typos make us look really silly.

(2/2) upgrading cups [######################] 100%
daemon srcript has been renamed to /etc/rc.d/cupsd
change your entry in /etc/rc.conf

"srcript" is not a word.

Loading...