FS#24930 - [initscripts] '/sbin/rc.d/netfs' return code checking error in start/stop

Attached to Project: Arch Linux
Opened by Igor V. Mashentsev (BeerMan) - Tuesday, 28 June 2011, 16:56 GMT
Last edited by Tom Gundersen (tomegun) - Monday, 25 July 2011, 21:54 GMT
Task Type Bug Report
Category Packages: Core
Status Closed
Assigned To Tom Gundersen (tomegun)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
May be i'm mistake...
But i seen syntax error in 'if' structure: missing '$' symbol for 'rc' variable.

Additional info:
* package version: initscripts-2011.06.4-1

My patch is attached to this report.

Sorry for bad English :-)
   netfs.patch (0.6 KiB)
This task depends upon

Closed by  Tom Gundersen (tomegun)
Monday, 25 July 2011, 21:54 GMT
Reason for closing:  Not a bug
Comment by Igor V. Mashentsev (BeerMan) - Wednesday, 29 June 2011, 05:17 GMT
I'm sorry!
Path to file is: /etc/rc.d/netfs
Comment by Tom Gundersen (tomegun) - Monday, 25 July 2011, 21:53 GMT
Thanks for the report. I think the current code is correct, as we don't need to use $ inside (( )). Have a look in "man bash" under "ARITHMETIC EXPRESSIONS" it says: "Within an expression, shell variables may also be referenced by name without using the parameter expansion syntax".
Comment by Tom Gundersen (tomegun) - Monday, 25 July 2011, 21:54 GMT
If I'm wrong, and this code actually creates a problem for you, please reopen.

Loading...