Arch Linux

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#24923 - [nvidia], [nvidia-utils] use better bash syntax in PKGBUILD

Attached to Project: Arch Linux
Opened by Martin Kühne (mar77i) - Tuesday, 28 June 2011, 11:15 GMT
Last edited by Ionut Biru (wonder) - Tuesday, 04 October 2011, 07:02 GMT
Task Type General Gripe
Category Packages: Extra
Status Closed
Assigned To Ionut Biru (wonder)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
use better bash syntax in nvidia pkgbuilds. we know they work, but ...

- clean up indents
- use more quotes
- loop on find correctly (the soname loop is still way too ugly!)
- sed can take several commands delimited by semicolon
- use [[ -e ]] to test if a symlink should be created
   nvidia.patch (2 KiB)
   nvidia-utils.patch (6.6 KiB)
This task depends upon

Closed by  Ionut Biru (wonder)
Tuesday, 04 October 2011, 07:02 GMT
Reason for closing:  Fixed
Comment by Ionut Biru (wonder) - Tuesday, 28 June 2011, 11:26 GMT
- use more quotes

i see that you remove all quotes
Comment by Martin Kühne (mar77i) - Tuesday, 28 June 2011, 11:40 GMT
</difflexic-mode>
   nvidia.patch (2 KiB)
   nvidia-utils.patch (6.6 KiB)
Comment by Martin Kühne (mar77i) - Tuesday, 28 June 2011, 11:44 GMT
heh, if someone could delete the other diffs, too, just noticed I messed up indents even more than actual cleaning.
Update: I seem to have a bad day. could be related to the way diff works, as well. nvm...
Comment by Ionut Biru (wonder) - Monday, 03 October 2011, 19:08 GMT
sorry mate, i forgot about this. can you refresh the patch and i will commit ASAP
Comment by Martin Kühne (mar77i) - Monday, 03 October 2011, 22:56 GMT
patches, incrementally:

Patch 1: bashify/reindent the soname loop
Patch 2: quote and unify all lowercase variable expansions

Thanks for the pointer. Looked pretty good already, anyway. :)
   bashloops.patch (0.9 KiB)
   unifiedvar_and_quoting.patch (3.8 KiB)

Loading...