FS#24327 - [xfce4-session] New gdm confuse xfce4-session with GDM_LANG

Attached to Project: Arch Linux
Opened by Loïc Pefferkorn (loicp) - Tuesday, 17 May 2011, 22:43 GMT
Last edited by Andreas Radke (AndyRTR) - Monday, 22 August 2011, 13:07 GMT
Task Type Bug Report
Category Upstream Bugs
Status Closed
Assigned To Andreas Radke (AndyRTR)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Copy/paste description from upstream bug report https://bugzilla.xfce.org/show_bug.cgi?id=7400

>New gdm has GDM_LANG set to "" which confuses xfce4-session, resulting in a
>null LANG being set instead of whatever should be in there.
>
>Downstream report:
>
>https://bugzilla.redhat.com/show_bug.cgi?id=683941
>
>Simple patch:
>
>Only use GDM_LANG if not empty
>
>gdm >= 2.91 sets GDM_LANG to an empty string which xfce-session
>ends up using, overriding existing good LANG and breaking up utf8 etc.
>
>diff -up xfce4-session-4.8.1/xfce4-session/main.c.gdmlang
>xfce4-session-4.8.1/xfce4-session/main.c
>--- xfce4-session-4.8.1/xfce4-session/main.c.gdmlang 2011-03-10
>15:59:08.000000000 +0200
>+++ xfce4-session-4.8.1/xfce4-session/main.c 2011-03-10 15:59:30.000000000
>+0200
>@@ -103,7 +103,7 @@ setup_environment (void)
>
> /* this is for compatibility with the GNOME Display Manager */
> lang = g_getenv ("GDM_LANG");
>- if (lang != NULL)
>+ if (lang != NULL && strlen (lang) > 0)
> {
> xfce_setenv ("LANG", lang, TRUE);
> xfce_unsetenv ("GDM_LANG");

My patch simply update the package with this patch.
Thanks to Kevin Fenzi for the original patch.

Successfully tested on a fr_FR.UTF-8 environnement broken by a recent upgrade.
This task depends upon

Closed by  Andreas Radke (AndyRTR)
Monday, 22 August 2011, 13:07 GMT
Reason for closing:  Fixed
Additional comments about closing:  4.8.1-3

Loading...