Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines
Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.
REPEAT: Do NOT report bugs for outdated packages!
https://wiki.archlinux.org/title/Bug_reporting_guidelines
Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.
REPEAT: Do NOT report bugs for outdated packages!
FS#24284 - [p7zip] Nasm not needed; other PKGBUILD suggestions
Attached to Project:
Arch Linux
Opened by Marty (vadmium) - Sunday, 15 May 2011, 09:19 GMT
Last edited by Gaetan Bisson (vesath) - Sunday, 15 May 2011, 13:26 GMT
Opened by Marty (vadmium) - Sunday, 15 May 2011, 09:19 GMT
Last edited by Gaetan Bisson (vesath) - Sunday, 15 May 2011, 13:26 GMT
|
DetailsAttached patch for PKGBUILD with some suggested changes.
The main one is Nasm is only required for i686 target architecture builds. The change does add to the complexity but I thought I’d see if you’re okay with it. Similarly I presume Yasm is only needed for 64 bit, not 32 bit, but I haven’t tested this; I just quickly scanned the Make files. Other changes I suggest: + No need to patch usr/local out of the Make file since install command already uses DEST_HOME + Install with DEST_DIR instead of patching pkgdir out of the installed wrapper “binaries” + I got rid of the DEST_SHARE_DOC oddness. This means it installs HTML documentation properly, instead of the man pages pointing at some web site. Background: https://aur.archlinux.org/packages.php?K=p7zip-gui 
p7zip-9.20.1-1+vad0.diff
(1.2 KiB)
|
This task depends upon
Closed by Gaetan Bisson (vesath)
Sunday, 15 May 2011, 13:26 GMT
Reason for closing: Implemented
Additional comments about closing: p7zip-9.20.1-2 in [extra]
Sunday, 15 May 2011, 13:26 GMT
Reason for closing: Implemented
Additional comments about closing: p7zip-9.20.1-2 in [extra]
I have implemented most of them except the makedepends switch: it adds complexity (and makes it difficult to parse the PKGBUILD) for virtually no gain.
However, I had to chmod the files under /usr/share/doc/ otherwise they get installed with u-w permissions (so you can't untar the package as non-root).