Release Engineering

Tasklist

FS#24203 - archiso: the rc.conf template included in default config does not work correrctly

Attached to Project: Release Engineering
Opened by Roman Widmann (archme) - Tuesday, 10 May 2011, 09:06 GMT
Last edited by Evangelos Foutras (foutrelis) - Saturday, 30 July 2011, 09:31 GMT
Task Type Bug Report
Category ArchISO
Status Closed
Assigned To No-one
Architecture All
Severity Low
Priority Normal
Reported Version 2010.05
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
The rc.conf template included in default config (syslinux-iso) does not work correrctly.
(http://projects.archlinux.org/archiso.git/tree/configs/syslinux-iso/overlay/etc/rc.conf)

eg:
TIMEZONE="$(kernel_cmdline timezone ${TIMEZONE_DEFAULT})"
If timezone is not supplied as kernel parameter, TIMEZONE will not be set to TIMEZONE_DEFAULT.
Instead TIMEZONE will just be "null".

I think it should be somthing like:
TIMEZONE="$(kernel_cmdline timezone || echo ${TIMEZONE_DEFAULT})"
This task depends upon

Closed by  Evangelos Foutras (foutrelis)
Saturday, 30 July 2011, 09:31 GMT
Reason for closing:  Fixed
Comment by Gerardo Exequiel Pozzi (djgera) - Tuesday, 10 May 2011, 23:36 GMT
  • Field changed: Attached to Project (Arch Linux → Release Engineering)
Thanks, this is broken due changed behaviour in helper function, since this commit.

http://projects.archlinux.org/archiso.git/commit/?id=b171f8f11fdc04a22c7b8f3ff3b9dd164986daae
Comment by Gerardo Exequiel Pozzi (djgera) - Tuesday, 10 May 2011, 23:57 GMT
Fixed. http://projects.archlinux.org/archiso.git/commit/?id=90981fa285fd27ea3004c64f9d3d6ead19e86a7f

Loading...