The issue tracker has been moved https://gitlab.archlinux.org/archlinux/archiso/-/issues
FS#24158 - [2011.04.30] Invalid entries in fstab for partitions witout labels
Attached to Project:
Release Engineering
Opened by Mihai Militaru (akephalos) - Saturday, 07 May 2011, 22:22 GMT
Last edited by Dieter Plaetinck (Dieter_be) - Thursday, 18 August 2011, 20:00 GMT
Opened by Mihai Militaru (akephalos) - Saturday, 07 May 2011, 22:22 GMT
Last edited by Dieter Plaetinck (Dieter_be) - Thursday, 18 August 2011, 20:00 GMT
|
DetailsWhen, in the installer, the user chooses to use labels, to manually set filesystems and mount points, the partitions that don't have labels are incorrectly written in fstab, no identifier being set.
To reproduce: Use test partitions like: - sda1 - ext4 to mount in /root; label ROOT; - sda2 - swap to use as swap; label SWAP; - sda3 - ext4 to mount in /home; it has _no label_ and needs to keep the data intact. In the installer, choose: - "Manually configure block devices, ..."; - "label - by Disk-Label (Will use the filesystem labels ..."; - choose the mount points as intended. At the end, these entries will be found in fstab: LABEL= /home ext4 defaults 0 1 LABEL=ROOT / ext4 defaults 0 1 LABEL=SWAP swap swap defaults 0 1 |
This task depends upon
Closed by Dieter Plaetinck (Dieter_be)
Thursday, 18 August 2011, 20:00 GMT
Reason for closing: Fixed
Additional comments about closing: confirmed by pierre 2011.08.18
Thursday, 18 August 2011, 20:00 GMT
Reason for closing: Fixed
Additional comments about closing: confirmed by pierre 2011.08.18
We refactored the code on 2011-02-08
http://projects.archlinux.org/aif.git/commit/?id=adfa636f228aea89341ddcfd7cd9c927d8dd2242
before: do getlabel $part, if result is non-zero length use it, otherwise refer to blockdevice.
new approach: if getlabel() returns code 0, use its result, otherwise refer to blockdevice. getlabel() returns >0 when the label is empty.
So i don't get it. this should work.
It's also worth noting that the syslinux config becomes:
APPEND root=/dev/disk/by-label/
And similarily, bootloader config comes from get_kernel_parameters, where the getlabel call must return 0 before rootpart gets referenced by its label. I don't get this shit.
please confirm