FS#23963 - [git] PKGBUILD ignores CFLAGS/LDFLAGS

Attached to Project: Arch Linux
Opened by Kristoffer Tidemann (ktide) - Wednesday, 27 April 2011, 17:17 GMT
Last edited by Dan McGee (toofishes) - Thursday, 05 May 2011, 13:20 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Dan McGee (toofishes)
Architecture All
Severity Very Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Quick view into the Makefile shows this:

# CFLAGS and LDFLAGS are for the users to override from the command line.

CFLAGS = -g -O2 -Wall
LDFLAGS =


FIX:

make V=1 CFLAGS="${CFLAGS}" LDFLAGS="${LDFLAGS}" .....

Applies to both makes in the PKGBUILD. V=1 makes the build verbose.
This task depends upon

Closed by  Dan McGee (toofishes)
Thursday, 05 May 2011, 13:20 GMT
Reason for closing:  Fixed
Additional comments about closing:  1.7.5.1-1
Comment by Dan McGee (toofishes) - Wednesday, 27 April 2011, 22:45 GMT
Both makes? Only one should actually be making any object files.
Comment by Dan McGee (toofishes) - Wednesday, 27 April 2011, 22:49 GMT
Ahh, it seems it thinks new build flags happened if you don't specify them twice. Silly, but noted. This will be fixed next time I rebuild git.

Loading...