Arch Linux

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#23779 - mkinitcpio - no multiple adding of BINARIES

Attached to Project: Arch Linux
Opened by Dennis Schneck (ds) - Friday, 15 April 2011, 14:38 GMT
Last edited by Thomas Bächler (brain0) - Saturday, 14 May 2011, 10:47 GMT
Task Type Bug Report
Category Packages: Core
Status Closed
Assigned To Tobias Powalowski (tpowa)
Thomas Bächler (brain0)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description: mkinitcpio do not accept (include) multiple files from BINARIES in /etc/mkinicpio.conf

for example (/etc/mkinicpio.conf)

BINARIES="gpg2 find file"

the problem is in the /lib/initcpio/functions file,
in the function: add_binary
Only on time hit, so only one file is in the list to add
because the output of which is:
/usr/bin/gpg2
/usr/bin/find
/usr/bin/file

Additional info:
* package version(s)

mkinitcpio 0.6.8-2

* config and/or log files etc.


Steps to reproduce:

add 2 or 3 BINARIES in /etc/mkinicpio.conf (like example above)

# mkinitcpio -v -k 2.6.38-ARCH -g /boot/kernel26.img

now you can see that only one (in this case only gpg2) file is included to the initfile: kernel26.img

here is a little fix version (using a simple loop) from a college of mine


add_binary ()
{
local bin dest type lib
for bins in `echo ${1}`
do
bin=$(which "${bins}")
if [ $? -ne 0 ]; then
bin="${bins}"
fi

...
...
done
}


orginal version

add_binary ()
{
local bin dest type lib
bin=$(which "${1}")
if [ $? -ne 0 ]; then
bin="${1}"
fi

...
...
}
This task depends upon

Closed by  Thomas Bächler (brain0)
Saturday, 14 May 2011, 10:47 GMT
Reason for closing:  Works for me
Additional comments about closing:  Just tested, adding multiple binaries works as it should.
Comment by Jelle van der Waa (jelly) - Friday, 15 April 2011, 16:16 GMT
please add patches as attachments.
Comment by Jan de Groot (JGC) - Monday, 18 April 2011, 07:11 GMT
Works fine here without any modification. The add_binary function is called for every binary in BINARIES. The function itself doesn't need to iterate.

Loading...